* Re: [RFC][PATCH] Secure Deletion and Trash-Bin Support for Ext4
[not found] ` <20061206091100.GA33919298@melbourne.sgi.com>
@ 2006-12-06 22:16 ` Nathan Scott
0 siblings, 0 replies; only message in thread
From: Nathan Scott @ 2006-12-06 22:16 UTC (permalink / raw)
To: David Chinner; +Cc: Nikolai Joukov, linux-fsdevel, linux-ext4, xfs
On Wed, 2006-12-06 at 20:11 +1100, David Chinner wrote:
> ...
> If all we need to add to XFS is support for those flags, then XFS
> support would be trivial to add.
>
> Oh, damn. I take that back. We're almost out of flag space in the on
> disk inode - these two flags would use the last 2 flag bits so this
> may require an on disk inode format change in XFS. This will be
> a little more complex than I first thought, ...
It should be OK - you can do it without an inode version revision
if you take a second 16 bits for "di_flags2" from here...
xfs_dinode_core {
...
__uint8_t di_pad[8]; /* unused, zeroed space */
Its guaranteed zeroed initially (i.e. all flags unset) and the XFS
get/set flags APIs are 32 bits, so you should be OK there.
Also, it may also be possible to reclaim di_onlink at some point (maybe
now, since 16 bits would be good here) if mkfs.xfs is changed to always
create v2 inodes (dynamic conversion ATM IIRC)... not 100% sure though,
needs more code analysis.
cheers.
--
Nathan
^ permalink raw reply [flat|nested] only message in thread