From: Nathan Scott <nscott@aconex.com>
To: Utako Kusaka <utako@tnes.nec.co.jp>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] Fix segmentation fault when using xfs_quota state command.
Date: Fri, 27 Apr 2007 13:58:22 +1000 [thread overview]
Message-ID: <1177646302.6273.386.camel@edge> (raw)
In-Reply-To: <200704270240.AA05279@TNESG9305.tnes.nec.co.jp>
On Fri, 2007-04-27 at 11:40 +0900, Utako Kusaka wrote:
> + if (!fs_count)
> + return 0;
> +
Is the segfault due to this line in state.c?
237 else if (fs_path->fs_flags & FS_MOUNT_POINT)
If so, a fix that is more clear to the reader might be:
- else if (fs_path->fs_flags & FS_MOUNT_POINT)
+ else if (fs_path && fs_path->fs_flags & FS_MOUNT_POINT)
This keeps the fix alongside the problematic access to fs_path.
cheers.
--
Nathan
next prev parent reply other threads:[~2007-04-27 3:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 2:40 [PATCH] Fix segmentation fault when using xfs_quota state command Utako Kusaka
2007-04-27 3:58 ` Nathan Scott [this message]
2007-04-27 7:42 ` Utako Kusaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1177646302.6273.386.camel@edge \
--to=nscott@aconex.com \
--cc=utako@tnes.nec.co.jp \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox