On Tue, 2007-05-22 at 11:03 +1000, David Chinner wrote: > On Tue, May 22, 2007 at 11:02:59AM +1000, Nathan Scott wrote: > > On Tue, 2007-05-22 at 10:44 +1000, David Chinner wrote: > > > On Mon, May 21, 2007 at 04:34:26PM +1000, Timothy Shimmin wrote: > > > I guess I need to ping Christoph and Nathan on this one.... > > > > Could you resend the patch to me please? I lost the previous copy > > while ruthlessly ploughing through my mail backlog. ;) > > Below. Looks pretty good to me - xfs_convert_page has been overlooked, I think - attached patch fixes that. You also initialise iomap_valid twice inside xfs_page_state_convert now ... I reverted that to just the once. cheers. -- Nathan