From: Nathan Scott <nscott@aconex.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH, RFC] - remove mounpoint UUID code
Date: Tue, 11 Mar 2008 11:44:12 +1100 [thread overview]
Message-ID: <1205196252.15982.69.camel@edge.scott.net.au> (raw)
In-Reply-To: <47D20F78.7000103@sandeen.net>
On Fri, 2008-03-07 at 22:00 -0600, Eric Sandeen wrote:
> It looks like all of the below is unused... and according
> to Nathan,
>
> "dont think it even got used/implemented anywhere, but i think it
> was meant to be an auto-mount kinda thing... such that when you look
> up at that point, it knows to mount the device with that uuid there,
> if its not already it was never really written anywhere ... just an
> idea in doug doucettes brain i think."
>
> Think it'll ever go anywhere, or should it get pruned?
>
> The below builds; not at all tested, until I get an idea if it's worth
> doing. Need to double check that some structures might not need padding
> out to keep things compatible/consistent...
Since effectively all versions of XFS support this feature ondisk,
including complete support in recovery, it would be better IMO to
leave it in for someone to implement/experiment with the syscall
and auto-mounting userspace support. That would then require no
new feature bits, mkfs/repair changes, etc. There is effectively
zero cost to leaving it there - and non-zero cost in removing it,
if our seriously bad regression-via-cleanup history is anything
to go by ... :|
It would be really unfortunate to remove this, and then find that
it was useful to someone (who didn't know about it at this time).
OTOH, if there is definately never ever any chance this can ever
be useful, then it should indeed be removed. :)
cheers.
--
Nathan
next prev parent reply other threads:[~2008-03-11 0:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 4:00 [PATCH, RFC] - remove mounpoint UUID code Eric Sandeen
2008-03-08 4:31 ` Ian Costello
2008-03-08 4:33 ` Eric Sandeen
2008-03-08 4:40 ` Ian Costello
2008-03-08 4:59 ` Eric Sandeen
2008-03-08 11:54 ` Christoph Hellwig
2008-03-11 0:44 ` Nathan Scott [this message]
2008-03-11 1:19 ` Eric Sandeen
2008-03-11 20:09 ` nscott
2008-03-12 7:22 ` Christoph Hellwig
2008-07-08 3:09 ` [PATCH, RFC] - remove mountpoint " Eric Sandeen
2008-07-25 2:22 ` [PATCH, RFC] - remove mounpoint " Niv Sardi
2008-07-25 3:11 ` Eric Sandeen
2008-07-25 5:12 ` Niv Sardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205196252.15982.69.camel@edge.scott.net.au \
--to=nscott@aconex.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox