From: Jan Tulak <jtulak@redhat.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: xfsprogs: useless code blocks
Date: Mon, 20 Jul 2015 09:57:46 -0400 (EDT) [thread overview]
Message-ID: <1213913978.543970.1437400666553.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <2035333009.511763.1437398166766.JavaMail.zimbra@redhat.com>
Hi all,
I found these useless bits of code in xfsprogs:
repair/incore_ino.c:575-576:
if (ino_rec->ino_startnum == 0)
ino_rec = ino_rec;
This one is pretty clear. It is there since 2001 (commit 2bd0ea187
by nathans@sgi.com, who didn't wrote here since 2006, so I find
CC-ing him useless). It looks like a forgotten code which doesn't
do anything, but I ask in case it is a hidden bug.
And:
db/check.c:3035, 3037: Always true expression, as be32_to_cpu()
translates to __u32 type and unsigned can't be less than zero.
be32_to_cpu(free->hdr.nvalid) < 0 ||
Is there any reason for these tests? I get different type sizes, or
endians as platform dependent, but signed/unsigned? Or it is
a big/little endian conversion hack?
Cheers,
Jan
--
Jan Tulak
jtulak@redhat.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next parent reply other threads:[~2015-07-20 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2035333009.511763.1437398166766.JavaMail.zimbra@redhat.com>
2015-07-20 13:57 ` Jan Tulak [this message]
2015-07-21 6:37 ` xfsprogs: useless code blocks Dave Chinner
2015-07-21 9:18 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213913978.543970.1437400666553.JavaMail.zimbra@redhat.com \
--to=jtulak@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox