From: Boris Ranto <branto@redhat.com>
To: Junho Ryu <jayr@google.com>
Cc: tytso@mit.edu, hughd@google.com, xfs@oss.sgi.com
Subject: Re: [PATCH v2 09/12] xfstests: skip generic/076 which cannot work on tmpfs
Date: Wed, 18 Dec 2013 00:20:29 -0500 (EST) [thread overview]
Message-ID: <1243674646.8335146.1387344029069.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1387318722-3050-9-git-send-email-jayr@google.com>
Hi,
here, you were probably looking for -b option (that tests if its argument is a block device) instead of -d option (that tests if its argument is a directory). Otherwise, this patch would skip the test case for an arbitrary file system.
-Boris
----- Original Message -----
> Skip generic/076 which tests concurrent access while testing tmpfs
> because there are other tests cover the case using fsstress.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Junho Ryu <jayr@google.com>
> ---
>
> v2: check whether SCRATCH_DEV is a block device instead of checking whether
> FSTYP is tmpfs.
>
> tests/generic/076 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/generic/076 b/tests/generic/076
> index a53840f..7ab2fbc 100755
> --- a/tests/generic/076
> +++ b/tests/generic/076
> @@ -57,6 +57,8 @@ _supported_os IRIX Linux
>
> _require_scratch
>
> +[ -d "$SCRATCH_DEV" ] || _notrun "this test requires block device"
> +
> echo "*** init fs"
>
> rm -f $seqres.full
> --
> 1.8.5.1
>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-18 5:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 22:18 [PATCH v2 01/12] xfstests: use mount point instead of device name Junho Ryu
2013-12-17 22:18 ` [PATCH v2 02/12] xfstests: _scratch_mkfs_sized() for tmpfs Junho Ryu
2013-12-18 5:33 ` Boris Ranto
2013-12-17 22:18 ` [PATCH v2 03/12] xfstests: increase tmpfs memory size Junho Ryu
2013-12-17 22:21 ` Junho Ryu
2013-12-17 22:18 ` [PATCH v2 04/12] xfstests: rename _require_xfs_io_fiemap to _require_fiemap Junho Ryu
2013-12-17 22:18 ` [PATCH v2 05/12] xfstests: fix generic/225 to check fiemap support Junho Ryu
2013-12-17 22:18 ` [PATCH v2 06/12] xfstests: fix generic/127 to call _cleanup() only once Junho Ryu
2013-12-17 22:18 ` [PATCH v2 07/12] xfstests: check O_DIRECT support before testing direct I/O Junho Ryu
2013-12-17 22:18 ` [PATCH v2 08/12] xfstests: add executable permission to tests Junho Ryu
2013-12-17 22:18 ` [PATCH v2 09/12] xfstests: skip generic/076 which cannot work on tmpfs Junho Ryu
2013-12-18 5:20 ` Boris Ranto [this message]
2013-12-17 22:18 ` [PATCH v2 10/12] xfstests: do not unmount tmpfs during remount Junho Ryu
2013-12-17 22:18 ` [PATCH v2 11/12] xfstests: do not unmount before calling _check_scratch_fs() Junho Ryu
2013-12-17 22:18 ` [PATCH v2 12/12] xfstests: check if filesystem supports chattr Junho Ryu
2013-12-17 22:23 ` Junho Ryu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243674646.8335146.1387344029069.JavaMail.root@redhat.com \
--to=branto@redhat.com \
--cc=hughd@google.com \
--cc=jayr@google.com \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).