From: "Theodore Ts'o" <tytso@mit.edu>
To: xfs@oss.sgi.com
Cc: tytso@mit.edu
Subject: [PATCH 1/3] Skip _check_test_fs unless a test is actually run
Date: Fri, 19 Jun 2009 13:53:31 -0400 [thread overview]
Message-ID: <1245434013-9433-1-git-send-email-tytso@mit.edu> (raw)
Running _check_test_fs can take a non-trivial amount of time, and if a
test has been skipped because it doesn't work on Linux, or it doesn't
work of for ext4, it's pointless to re-run _check_test_fs. So move
the call to _check_test_fs so it is only run if a test is actually run.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
check | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/check b/check
index 545c010..1aae528 100755
--- a/check
+++ b/check
@@ -308,10 +308,10 @@ do
then
try="$try $seq"
n_try=`expr $n_try + 1`
+ _check_test_fs
fi
seq="after_$seq"
- _check_test_fs
done
interrupt=false
--
1.6.3.2.1.gb9f7d.dirty
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2009-06-19 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 17:53 Theodore Ts'o [this message]
2009-06-19 17:53 ` [PATCH 2/3] Fix common.config to allow SCRATCH_DEV and SCRATCH_MNT to be optional Theodore Ts'o
2009-06-20 17:15 ` Christoph Hellwig
2009-06-19 17:53 ` [PATCH 3/3] Fix _require_scratch test for extN, resierfs, gfs2, and btrfs Theodore Ts'o
2009-06-19 19:16 ` Felix Blyakher
2009-06-19 20:28 ` [PATCH] " Theodore Ts'o
2009-06-20 17:07 ` Christoph Hellwig
2009-06-19 19:05 ` [PATCH 1/3] Skip _check_test_fs unless a test is actually run Felix Blyakher
2009-06-20 17:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245434013-9433-1-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox