From: "Theodore Ts'o" <tytso@mit.edu>
To: xfs@oss.sgi.com
Cc: tytso@mit.edu
Subject: [PATCH 2/3] Fix common.config to allow SCRATCH_DEV and SCRATCH_MNT to be optional
Date: Fri, 19 Jun 2009 13:53:32 -0400 [thread overview]
Message-ID: <1245434013-9433-2-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1245434013-9433-1-git-send-email-tytso@mit.edu>
Commit 3ae9f2f8 purports to allow SCRATCH_DEV and SCRATCH_MNT to be
optional, but tests in common.config will cause check to exit with an
error if these environment variables are not defined. Fix this problem.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
common.config | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/common.config b/common.config
index 64df893..b304247 100644
--- a/common.config
+++ b/common.config
@@ -23,10 +23,10 @@
# mounted XFS file system, needs to be be world
# writeable
# TEST_DEV - device for file system containing TEST_DIR
-# SCRATCH_DEV - device you can make a scratch file system on
-# SCRATCH_MNT - mount point for scratch file system
#
# and optionally:
+# SCRATCH_DEV - device you can make a scratch file system on
+# SCRATCH_MNT - mount point for scratch file system
# SCRATCH_LOGDEV - scratch log device for external log testing
# SCRATCH_RTDEV - scratch rt dev
# TEST_LOGDEV - test log device for external log testing
@@ -202,8 +202,8 @@ known_hosts()
[ -z "$TEST_DIR" ] && MC="$MC TEST_DIR"
[ -z "$TEST_DEV" ] && MC="$MC TEST_DEV"
- [ -z "$SCRATCH_MNT" ] && MC="$MC SCRATCH_MNT"
- [ -z "$SCRATCH_DEV" ] && MC="$MC SCRATCH_DEV"
+# [ -z "$SCRATCH_MNT" ] && MC="$MC SCRATCH_MNT"
+# [ -z "$SCRATCH_DEV" ] && MC="$MC SCRATCH_DEV"
[ "$MC" ] && (echo "Warning: need to define parameters for host $HOST";\
echo " or set variables:"; \
--
1.6.3.2.1.gb9f7d.dirty
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-06-19 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 17:53 [PATCH 1/3] Skip _check_test_fs unless a test is actually run Theodore Ts'o
2009-06-19 17:53 ` Theodore Ts'o [this message]
2009-06-20 17:15 ` [PATCH 2/3] Fix common.config to allow SCRATCH_DEV and SCRATCH_MNT to be optional Christoph Hellwig
2009-06-19 17:53 ` [PATCH 3/3] Fix _require_scratch test for extN, resierfs, gfs2, and btrfs Theodore Ts'o
2009-06-19 19:16 ` Felix Blyakher
2009-06-19 20:28 ` [PATCH] " Theodore Ts'o
2009-06-20 17:07 ` Christoph Hellwig
2009-06-19 19:05 ` [PATCH 1/3] Skip _check_test_fs unless a test is actually run Felix Blyakher
2009-06-20 17:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245434013-9433-2-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox