[patch] xfsprogs: extend fiemap configure check

[patch] xfsprogs: extend fiemap configure check

[Nathan Scott]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

Make the fiemap configure check consistent with the other
libc interface checks - perform a compile and link with a
complete set of symbols, macros and interfaces needed, as
opposed to a build with just the headers.

Signed-off-by: Nathan Scott <nathans@debian.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fiemap.patch --]
[-- Type: text/x-patch; name=fiemap.patch, Size: 721 bytes --]

diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
index 8192181..1e2c256 100644
--- a/m4/package_libcdev.m4
+++ b/m4/package_libcdev.m4
@@ -121,6 +121,17 @@ AC_DEFUN([AC_HAVE_FALLOCATE],
 # Check if we have the fiemap ioctl (Linux)
 #
 AC_DEFUN([AC_HAVE_FIEMAP],
-  [ AC_CHECK_HEADERS([linux/fiemap.h], [ have_fiemap=yes ], [ have_fiemap=no ])
+  [ AC_MSG_CHECKING([for fiemap])
+    AC_TRY_LINK([
+#define _GNU_SOURCE
+#define _FILE_OFFSET_BITS 64
+#include <linux/fs.h>
+#include <linux/fiemap.h>
+    ], [
+         struct fiemap *fiemap;
+         ioctl(0, FS_IOC_FIEMAP, (unsigned long)fiemap);
+    ], have_fiemap=yes
+       AC_MSG_RESULT(yes),
+       AC_MSG_RESULT(no))
     AC_SUBST(have_fiemap)
   ])

[-- Attachment #3: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [patch] xfsprogs: extend fiemap configure check

[Christoph Hellwig]

On Wed, Feb 01, 2012 at 10:11:16AM +1100, Nathan Scott wrote:
> Make the fiemap configure check consistent with the other
> libc interface checks - perform a compile and link with a
> complete set of symbols, macros and interfaces needed, as
> opposed to a build with just the headers.
> 
> Signed-off-by: Nathan Scott <nathans@debian.org>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [patch] xfsprogs: extend fiemap configure check

[Dave Chinner]

On Wed, Feb 01, 2012 at 10:11:16AM +1100, Nathan Scott wrote:
> Make the fiemap configure check consistent with the other
> libc interface checks - perform a compile and link with a
> complete set of symbols, macros and interfaces needed, as
> opposed to a build with just the headers.
> 
> Signed-off-by: Nathan Scott <nathans@debian.org>

Definitely a good idea. 

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs