RE: [PATCH, updated] xfs: Ensure we force all busy extents inrange to disk

Alex Elder
2010-01-10T18:32:37Z

Christoph Hellwig wrote:
> Looks good,

Thanks, I will publish this today.

> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
>> TRACE_EVENT(xfs_alloc_busysearch,
>> TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, xfs_agblock_t agbno,
>> - xfs_extlen_t len, int found),
>> - TP_ARGS(mp, agno, agbno, len, found),
>> + xfs_extlen_t len, int found, xfs_lsn_t lsn),
>> + TP_ARGS(mp, agno, agbno, len, found, lsn),
>
> The found argument to this tracepoint can be dropped - with the new loop
> style it doesn't work anymore, and a non-zero lsn provides the same
> information.

I agree with that, and have now removed that argument
from the tracepoint, with the net effect that the lsn
argument simply replaces it.

-Alex