From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 4/4] xfs: Remove inode iolock held check during allocation
Date: Mon, 11 Jan 2010 10:51:48 +1100 [thread overview]
Message-ID: <1263167508-9346-5-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1263167508-9346-1-git-send-email-david@fromorbit.com>
lockdep complains about a the lock not being initialised as we do
an ASSERT based check that the lock is not held before we initialise
it to catch inodes freed with the lock held.
lockdep does this check for us in the lock initialisation code, so
remove the ASSERT to stop the lockdep warning.
Signed-off-by: Dave Chinner <david@fromorbit.com>
---
fs/xfs/xfs_iget.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c
index fa402a6..155e798 100644
--- a/fs/xfs/xfs_iget.c
+++ b/fs/xfs/xfs_iget.c
@@ -73,7 +73,6 @@ xfs_inode_alloc(
ASSERT(atomic_read(&ip->i_pincount) == 0);
ASSERT(!spin_is_locked(&ip->i_flags_lock));
ASSERT(completion_done(&ip->i_flush));
- ASSERT(!rwsem_is_locked(&ip->i_iolock.mr_lock));
mrlock_init(&ip->i_iolock, MRLOCK_BARRIER, "xfsio", ip->i_ino);
--
1.6.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-10 23:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 23:51 [PATCH 0/4] 2.6.33-rcX candidate fixes Dave Chinner
2010-01-10 23:51 ` [PATCH 1/4] xfs: reclaim inodes under a write lock Dave Chinner
2010-01-11 10:18 ` Christoph Hellwig
2010-01-10 23:51 ` [PATCH 2/4] xfs: Avoid inodes in reclaim when flushing from inode cache Dave Chinner
2010-01-11 10:19 ` Christoph Hellwig
2010-01-10 23:51 ` [PATCH 3/4] xfs: reclaim all inodes by background tree walks Dave Chinner
2010-01-11 10:19 ` Christoph Hellwig
2010-01-10 23:51 ` Dave Chinner [this message]
2010-01-11 10:20 ` [PATCH 4/4] xfs: Remove inode iolock held check during allocation Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263167508-9346-5-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox