From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 2/4] xfsqa: make unmounting loop devices in 073 work again
Date: Tue, 12 Jan 2010 15:41:07 +1100 [thread overview]
Message-ID: <1263271269-18997-3-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1263271269-18997-1-git-send-email-david@fromorbit.com>
Loop devices are now created and destroyed on demand, and
the existing hacks to do this no longer work. Remove them.
Signed-off-by: Dave Chinner <david@fromorbit.com>
---
073 | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/073 b/073
index 5059448..ac4c64f 100755
--- a/073
+++ b/073
@@ -3,15 +3,6 @@
#
# Test xfs_copy
#
-# HACK WARNING:
-#
-# Due to the severe brokenness of mount's handling of loopback devices, we
-# hardcode the loop devices we use for this test. This enables us to clean up
-# the pieces when we remount the loop device because mount loses all trace of
-# the fact this is a loop device. Hence to enable us to unmount the hosting
-# filesystem, we need to manually tear down the relevant loop device. If
-# mount ever gets fixed then this hack can be removed.
-#
#-----------------------------------------------------------------------
# Copyright (c) 2000-2003,2008 Silicon Graphics, Inc. All Rights Reserved.
#
@@ -127,9 +118,7 @@ _verify_copy()
diff -u $tmp.geometry1 $tmp.geometry2
echo unmounting and removing new image
- loop=`mount | grep $target | grep -o -e 'loop=.*[^),]' | grep -o -e '/.*$'`
- umount $source $target
- losetup -d $loop > /dev/null 2>&1
+ umount $source_dir $target_dir
rm -f $target
}
--
1.6.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-12 4:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 4:41 [PATCH 0/4] xfsqa: make some tests work again, add xfs_fsr test Dave Chinner
2010-01-12 4:41 ` [PATCH 1/4] xfsqa: filter the fsstress seed output in 104 Dave Chinner
2010-01-12 9:31 ` Christoph Hellwig
2010-01-12 4:41 ` Dave Chinner [this message]
2010-01-12 10:00 ` [PATCH 2/4] xfsqa: make unmounting loop devices in 073 work again Christoph Hellwig
2010-01-12 11:51 ` Dave Chinner
2010-01-12 4:41 ` [PATCH 3/4] xfsqa: filter log size in 206 Dave Chinner
2010-01-12 9:47 ` Christoph Hellwig
2010-01-12 4:41 ` [PATCH 4/4] xfsqa: add simple xfs_fsr test Dave Chinner
2010-01-12 9:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263271269-18997-3-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox