From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/8] xfs: clean up pointer sign differences
Date: Tue, 19 Jan 2010 11:30:18 +1100 [thread overview]
Message-ID: <1263861026-13448-1-git-send-email-david@fromorbit.com> (raw)
This patch series cleans up all the pointer sign warnings when they
are turned back on in the XFS build. These are the kernel
equivalents of the libxfs changes I posted a last week. On
Christoph's suggestion, I've made the changes for the kernel code so
that we can fix the libxfs warnings simply by resyncing the userspce
code with the kernel code.
Hence this makes all of the directory and attribute names and values
unsigned chars and uses that consistently within XFS. The on disk
formats are all unsigned, but the VFS is a mix of signed and
unsigned interfaces.
The series converts all the names and values at the highest
level to unsigned so the rest of the code doesn't need to juggle
different signedness. It cleans up all the places where we have
cast pointers, makes all functions take unsigned strings and so on.
Finally, it turns on the pointer sign warnings again (which are
actually turned off globally in the build) so that we don't
reintroduce new problems due to a lack of warnings being produced by
the compiler.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-01-19 0:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 0:30 Dave Chinner [this message]
2010-01-19 0:30 ` [PATCH 1/8] xfs: directory names are unsigned Dave Chinner
2010-01-19 9:24 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 2/8] xfs: convert DM ops to use unsigned char names Dave Chinner
2010-01-19 9:25 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 3/8] xfs: convert dirnameops to " Dave Chinner
2010-01-19 9:25 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 4/8] xfs: make xfs_dir_cilookup_result use unsigned char Dave Chinner
2010-01-19 9:26 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 5/8] xfs: xfs_buf_iomove() doesn't care about signedness Dave Chinner
2010-01-19 9:27 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 6/8] xfs: convert attr to use unsigned names Dave Chinner
2010-01-19 9:32 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 7/8] xfs: clean up sign warnings in dir2 code Dave Chinner
2010-01-19 9:27 ` Christoph Hellwig
2010-01-19 0:30 ` [PATCH 8/8] xfs: make compile warn about char sign mismatches again Dave Chinner
2010-01-19 9:29 ` Christoph Hellwig
2010-01-19 11:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263861026-13448-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox