Re: [PATCH 4/8] xfs: make xfs_dir_cilookup_result use unsigned char

Christoph Hellwig
2010-01-19T09:25:48Z

On Tue, Jan 19, 2010 at 11:30:22AM +1100, Dave Chinner wrote:
> For consistency with the result of the code.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
> ---
> fs/xfs/xfs_dir2.c | 2 +-
> fs/xfs/xfs_dir2.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_dir2.c b/fs/xfs/xfs_dir2.c
> index c21c527..3a8c6ba 100644
> --- a/fs/xfs/xfs_dir2.c
> +++ b/fs/xfs/xfs_dir2.c
> @@ -247,7 +247,7 @@ xfs_dir_createname(
> int
> xfs_dir_cilookup_result(
> struct xfs_da_args *args,
> - const char *name,
> + const unsigned char *name,
> int len)
> {

Given that the value we copy things into is unsigned anyway this looks
correct,

Reviewed-by: Christoph Hellwig <hch@lst.de>