From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 1/7] xfsprogs: fix missing error check in xfs_rtfree_range in libxfs
Date: Tue, 19 Jan 2010 11:36:47 +1100 [thread overview]
Message-ID: <1263861413-13729-2-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1263861413-13729-1-git-send-email-david@fromorbit.com>
When xfs_rtfind_forw() returns an error, the block is returned
uninitialised. xfs_rtfree_range() is not checking the error return,
so could be using an uninitialised block number for modifying bitmap
summary info.
Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
libxfs/xfs_rtalloc.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libxfs/xfs_rtalloc.c b/libxfs/xfs_rtalloc.c
index 6c3da52..4fbdaa9 100644
--- a/libxfs/xfs_rtalloc.c
+++ b/libxfs/xfs_rtalloc.c
@@ -466,6 +466,8 @@ xfs_rtfree_range(
*/
error = xfs_rtfind_forw(mp, tp, end, mp->m_sb.sb_rextents - 1,
&postblock);
+ if (error)
+ return error;
/*
* If there are blocks not being freed at the front of the
* old extent, add summary data for them to be allocated.
--
1.6.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-19 0:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 0:36 [PATCH 0/7] xfsprogs: Fix build warnings V3 Dave Chinner
2010-01-19 0:36 ` Dave Chinner [this message]
2010-01-19 0:36 ` [PATCH 2/7] xfsprogs: fix warning in adfs superblock probe Dave Chinner
2010-01-19 0:36 ` [PATCH 3/7] xfsprogs: fix some trivial warnings in xfs_db Dave Chinner
2010-01-19 9:21 ` Christoph Hellwig
2010-01-19 9:34 ` Christoph Hellwig
2010-01-19 0:36 ` [PATCH 4/7] xfsprogs: fix trivial warnings in xfs_fsr Dave Chinner
2010-01-19 0:36 ` [PATCH 5/7] xfsprogs: fix print format warnings in xfs_io Dave Chinner
2010-01-19 0:36 ` [PATCH 6/7] xfsprogs: fix sign warning in mkfs directory code Dave Chinner
2010-01-19 0:36 ` [PATCH 7/7] xfsprogs: fix build warnings in repair V2 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263861413-13729-2-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox