From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 3/7] xfsprogs: fix some trivial warnings in xfs_db
Date: Tue, 19 Jan 2010 11:36:49 +1100 [thread overview]
Message-ID: <1263861413-13729-4-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1263861413-13729-1-git-send-email-david@fromorbit.com>
Three warnings, none harmful - one dir2 name sign warning and
two cases where gcc can't work out if a variable is initialised
correctly in a child function or not.
Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
db/check.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/db/check.c b/db/check.c
index 7620d9c..f94a16b 100644
--- a/db/check.c
+++ b/db/check.c
@@ -2317,7 +2317,7 @@ process_data_dir_v2(
tag_err += be16_to_cpu(*tagp) != (char *)dep - (char *)data;
addr = xfs_dir2_db_off_to_dataptr(mp, db,
(char *)dep - (char *)data);
- xname.name = (char *)dep->name;
+ xname.name = (uchar_t *)dep->name;
xname.len = dep->namelen;
dir_hash_add(mp->m_dirnameops->hashname(&xname), addr);
ptr += xfs_dir2_data_entsize(dep->namelen);
@@ -3059,7 +3059,7 @@ process_leaf_node_dir_v2(
xfs_ino_t lino;
int nex;
xfs_ino_t parent;
- int t;
+ int t = 0;
int v;
int v2;
int x;
@@ -3403,7 +3403,7 @@ process_quota(
xfs_fileoff_t qbno;
char *s = NULL;
int scicb;
- int t;
+ int t = 0;
switch (qtype) {
case IS_USER_QUOTA:
--
1.6.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-19 0:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 0:36 [PATCH 0/7] xfsprogs: Fix build warnings V3 Dave Chinner
2010-01-19 0:36 ` [PATCH 1/7] xfsprogs: fix missing error check in xfs_rtfree_range in libxfs Dave Chinner
2010-01-19 0:36 ` [PATCH 2/7] xfsprogs: fix warning in adfs superblock probe Dave Chinner
2010-01-19 0:36 ` Dave Chinner [this message]
2010-01-19 9:21 ` [PATCH 3/7] xfsprogs: fix some trivial warnings in xfs_db Christoph Hellwig
2010-01-19 9:34 ` Christoph Hellwig
2010-01-19 0:36 ` [PATCH 4/7] xfsprogs: fix trivial warnings in xfs_fsr Dave Chinner
2010-01-19 0:36 ` [PATCH 5/7] xfsprogs: fix print format warnings in xfs_io Dave Chinner
2010-01-19 0:36 ` [PATCH 6/7] xfsprogs: fix sign warning in mkfs directory code Dave Chinner
2010-01-19 0:36 ` [PATCH 7/7] xfsprogs: fix build warnings in repair V2 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263861413-13729-4-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox