Re: [PATCH 3/7] xfsprogs: fix some trivial warnings in xfs_db

Christoph Hellwig
2010-01-19T09:33:42Z

On Tue, Jan 19, 2010 at 11:36:49AM +1100, Dave Chinner wrote:
> Three warnings, none harmful - one dir2 name sign warning and
> two cases where gcc can't work out if a variable is initialised
> correctly in a child function or not.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> db/check.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/db/check.c b/db/check.c
> index 7620d9c..f94a16b 100644
> --- a/db/check.c
> +++ b/db/check.c
> @@ -2317,7 +2317,7 @@ process_data_dir_v2(
> tag_err += be16_to_cpu(*tagp) != (char *)dep - (char *)data;
> addr = xfs_dir2_db_off_to_dataptr(mp, db,
> (char *)dep - (char *)data);
> - xname.name = (char *)dep->name;
> + xname.name = (uchar_t *)dep->name;

Aren't hese now both unsigned after the kernel changes are sycned over?

And btw, please also avoid uchar_t in xfsprogs, it will be gone with
next full libxfs resync.