From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 3/3] xfsqa: xfs_check can see stale cached blocks
Date: Tue, 19 Jan 2010 20:03:12 +1100 [thread overview]
Message-ID: <1263891792-30952-4-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1263891792-30952-1-git-send-email-david@fromorbit.com>
Test 017 is consistently failing now because the xfs_check uses
buffered IO to read the block device and 017 runs xfs_check ona
remount,ro filesystem. Hence the block device cache is never
invalidated (the unmount path does this) and so xfs_check can see
stale blocks from previous invocations instead of what is really on
disk at the time it is run.
Manually trash the page cache before running xfs_check to ensure
that the blockdev cache is clean and we don't get false errors
from stale blocks.
Signed-off-by: Dave Chinner <david@fromorbit.com>
---
common.rc | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/common.rc b/common.rc
index 6424871..896e38d 100644
--- a/common.rc
+++ b/common.rc
@@ -318,6 +318,7 @@ _scratch_xfs_check()
SCRATCH_OPTIONS=""
[ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \
SCRATCH_OPTIONS="-l $SCRATCH_LOGDEV"
+ [ "$HOSTOS" = "Linux" ] && echo 1 > /proc/sys/vm/drop_caches
$XFS_CHECK_PROG $SCRATCH_OPTIONS $* $SCRATCH_DEV
}
@@ -931,6 +932,7 @@ _check_xfs_filesystem()
ok=0
fi
+ [ "$HOSTOS" = "Linux" ] && echo 1 > /proc/sys/vm/drop_caches
$XFS_CHECK_PROG $testoption $extra_log_options $device 2>&1 |\
_fix_malloc >$tmp.fs_check
if [ -s $tmp.fs_check ]
--
1.6.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-19 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 9:03 [PATCH 0/3] xfsqa: Fix various test-suite related failures Dave Chinner
2010-01-19 9:03 ` [PATCH 1/3] xfsqa: update 214 golden output Dave Chinner
2010-01-19 9:17 ` Christoph Hellwig
2010-01-19 9:03 ` [PATCH 2/3] xfsqa: Fix signal usage in aio-dio test code Dave Chinner
2010-01-19 9:18 ` Christoph Hellwig
2010-01-19 9:03 ` Dave Chinner [this message]
2010-01-19 9:19 ` [PATCH 3/3] xfsqa: xfs_check can see stale cached blocks Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263891792-30952-4-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox