public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH] xfstests: kill in 131 needs to be quiet
Date: Wed, 20 Jan 2010 16:58:46 +1100	[thread overview]
Message-ID: <1263967126-7603-1-git-send-email-david@fromorbit.com> (raw)

If the kill fails because the processes have already terminates,
the output from kill (no such process) will cause the test to
fail. Make sure kill doesn't output anything.

Signed-off-by: Dave Chinner <david@fromorbit.com>
---
 131 |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/131 b/131
index 9be0a14..783765e 100755
--- a/131
+++ b/131
@@ -34,8 +34,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 _cleanup()
 {
-    kill $locktest_pid2
-    kill $locktest_pid1
+    kill $locktest_pid2 2&>1 /dev/null
+    kill $locktest_pid1 2&>1 /dev/null
     _cleanup_testdir
 }
 
-- 
1.6.5

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2010-01-20  5:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20  5:58 Dave Chinner [this message]
2010-01-20  8:18 ` [PATCH] xfstests: kill in 131 needs to be quiet Christoph Hellwig
2010-01-20 22:02   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263967126-7603-1-git-send-email-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox