* [PATCH] xfstests: kill in 131 needs to be quiet
@ 2010-01-20 5:58 Dave Chinner
2010-01-20 8:18 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2010-01-20 5:58 UTC (permalink / raw)
To: xfs
If the kill fails because the processes have already terminates,
the output from kill (no such process) will cause the test to
fail. Make sure kill doesn't output anything.
Signed-off-by: Dave Chinner <david@fromorbit.com>
---
131 | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/131 b/131
index 9be0a14..783765e 100755
--- a/131
+++ b/131
@@ -34,8 +34,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
- kill $locktest_pid2
- kill $locktest_pid1
+ kill $locktest_pid2 2&>1 /dev/null
+ kill $locktest_pid1 2&>1 /dev/null
_cleanup_testdir
}
--
1.6.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfstests: kill in 131 needs to be quiet
2010-01-20 5:58 [PATCH] xfstests: kill in 131 needs to be quiet Dave Chinner
@ 2010-01-20 8:18 ` Christoph Hellwig
2010-01-20 22:02 ` Dave Chinner
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2010-01-20 8:18 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs
On Wed, Jan 20, 2010 at 04:58:46PM +1100, Dave Chinner wrote:
> If the kill fails because the processes have already terminates,
> the output from kill (no such process) will cause the test to
> fail. Make sure kill doesn't output anything.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
Yes, I see the same here,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests: kill in 131 needs to be quiet
2010-01-20 8:18 ` Christoph Hellwig
@ 2010-01-20 22:02 ` Dave Chinner
0 siblings, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2010-01-20 22:02 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Wed, Jan 20, 2010 at 03:18:07AM -0500, Christoph Hellwig wrote:
> On Wed, Jan 20, 2010 at 04:58:46PM +1100, Dave Chinner wrote:
> > If the kill fails because the processes have already terminates,
> > the output from kill (no such process) will cause the test to
> > fail. Make sure kill doesn't output anything.
> >
> > Signed-off-by: Dave Chinner <david@fromorbit.com>
>
> Yes, I see the same here,
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Pushed.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-20 22:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-20 5:58 [PATCH] xfstests: kill in 131 needs to be quiet Dave Chinner
2010-01-20 8:18 ` Christoph Hellwig
2010-01-20 22:02 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox