From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: optimize log flushing in xfs_fsync
Date: Thu, 11 Feb 2010 17:10:00 -0600 [thread overview]
Message-ID: <1265929800.2793.30.camel@doink1> (raw)
In-Reply-To: <20100205095755.GA30848@infradead.org>
On Fri, 2010-02-05 at 04:57 -0500, Christoph Hellwig wrote:
> If we have a pinned inode it must have a log item attached to it.
> Usually that log item will have ili_last_lsn already set, in which
> case we only need to flush the log up to that LSN instead of doing
> a full log force. This gives speedups of about 5% in some fsync
> heavy workloads.
This looks good. I was going to suggest:
ASSERT(ip->i_itemp != NULL);
before it's dereferenced, but a pinned inode had better
have an item pointer...
Reviewed-by: Alex Elder <aelder@sgi.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/xfs/xfs_vnodeops.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_vnodeops.c 2010-02-04 17:38:33.679254119 +0100
> +++ xfs/fs/xfs/xfs_vnodeops.c 2010-02-04 17:38:51.606006156 +0100
> @@ -626,8 +626,14 @@ xfs_fsync(
> * force the log.
> */
> if (xfs_ipincount(ip)) {
> - error = _xfs_log_force(ip->i_mount, XFS_LOG_SYNC,
> - &log_flushed);
> + if (ip->i_itemp->ili_last_lsn) {
> + error = _xfs_log_force_lsn(ip->i_mount,
> + ip->i_itemp->ili_last_lsn,
> + XFS_LOG_SYNC, &log_flushed);
> + } else {
> + error = _xfs_log_force(ip->i_mount,
> + XFS_LOG_SYNC, &log_flushed);
> + }
> }
> } else {
> /*
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-02-11 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 9:57 [PATCH] xfs: optimize log flushing in xfs_fsync Christoph Hellwig
2010-02-11 23:10 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265929800.2793.30.camel@doink1 \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox