From: Alex Elder <aelder@sgi.com>
To: xfs@oss.sgi.com
Subject: xfstests: honor comments in the test group file
Date: Fri, 26 Feb 2010 12:29:07 -0600 [thread overview]
Message-ID: <1267208947.2756.11.camel@doink> (raw)
There are some spots in the "group" file where test numbers have
groups listed after a '#' character, clearly intending for those
groups to be commented out. But the way the group list gets
generated that commenting doesn't work, and in fact these tests
explicitly *are* included in such commented-out groups.
This patch fixes that, stripping out all comments (which start with
a '#' character and end with a newline) from the file before
building the set of test numbers for a group.
Signed-off-by: Alex Elder <aelder@sgi.com>
---
common | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Index: b/common
===================================================================
--- a/common
+++ b/common
@@ -58,9 +58,10 @@ do
if $group
then
# arg after -g
- group_list=`sed -n <group -e 's/$/ /' -e "/^[0-9][0-9][0-9].*
$r /"'{
-s/ .*//p
-}'`
+ group_list=$(sed -n < group \
+ -e 's/#.*//' \
+ -e 's/$/ /' \
+ -e "/^[0-9][0-9][0-9].* $r /"'{ s/ .*//p }')
if [ -z "$group_list" ]
then
echo "Group \"$r\" is empty or not defined?"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-02-26 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 18:29 Alex Elder [this message]
2010-04-16 17:07 ` xfstests: honor comments in the test group file Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267208947.2756.11.camel@doink \
--to=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox