From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't warn on EAGAIN in inode reclaim
Date: Tue, 30 Mar 2010 13:30:34 -0500 [thread overview]
Message-ID: <1269973834.2738.46.camel@doink> (raw)
In-Reply-To: <1269930010-19174-1-git-send-email-david@fromorbit.com>
On Tue, 2010-03-30 at 17:20 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Any inode reclaim flush that returns EAGAIN will result in the inode
> reclaim being attempted again later. There is no need to issue a
> warning into the logs about this situation.
Looks good.
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Alex Elder <aelder@sgi.com>
> ---
> fs/xfs/linux-2.6/xfs_sync.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c
> index 97813e7..5a4731e 100644
> --- a/fs/xfs/linux-2.6/xfs_sync.c
> +++ b/fs/xfs/linux-2.6/xfs_sync.c
> @@ -820,10 +820,10 @@ xfs_reclaim_inode(
> * call into reclaim to find it in a clean state instead of waiting for
> * it now. We also don't return errors here - if the error is transient
> * then the next reclaim pass will flush the inode, and if the error
> - * is permanent then the next sync reclaim will relcaim the inode and
> + * is permanent then the next sync reclaim will reclaim the inode and
> * pass on the error.
> */
> - if (error && !XFS_FORCED_SHUTDOWN(ip->i_mount)) {
> + if (error && error != EAGAIN && !XFS_FORCED_SHUTDOWN(ip->i_mount)) {
> xfs_fs_cmn_err(CE_WARN, ip->i_mount,
> "inode 0x%llx background reclaim flush failed with %d",
> (long long)ip->i_ino, error);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-03-30 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 6:20 [PATCH] xfs: don't warn on EAGAIN in inode reclaim Dave Chinner
2010-03-30 18:30 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269973834.2738.46.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox