Re: [PATCH 07/12] xfs: Improve scalability of busy extent tracking

Christoph Hellwig
2010-05-08T17:13:38Z

Looks good, but a couple minor comments below:

Reviewed-by: Christoph Hellwig <hch@lst.de>

> diff --git a/fs/xfs/linux-2.6/xfs_quotaops.c b/fs/xfs/linux-2.6/xfs_quotaops.c
> index 1947514..2e73688 100644
> --- a/fs/xfs/linux-2.6/xfs_quotaops.c
> +++ b/fs/xfs/linux-2.6/xfs_quotaops.c
> @@ -19,6 +19,7 @@
> #include "xfs_dmapi.h"
> #include "xfs_sb.h"
> #include "xfs_inum.h"
> +#include "xfs_log.h"
> #include "xfs_ag.h"
> #include "xfs_mount.h"
> #include "xfs_quota.h"

This hunk is not needed.

> --- a/fs/xfs/xfs_log.h
> +++ b/fs/xfs/xfs_log.h
> @@ -18,9 +18,6 @@
> #ifndef __XFS_LOG_H__
> #define __XFS_LOG_H__
>
> -/* transaction ID type */
> -typedef __uint32_t xlog_tid_t;
> -

> --- a/fs/xfs/xfs_types.h
> +++ b/fs/xfs/xfs_types.h
> @@ -75,6 +75,8 @@ typedef __uint32_t xfs_dahash_t; /* dir/attr hash value */
>
> typedef __uint16_t xfs_prid_t; /* prid_t truncated to 16bits in XFS */
>
> +typedef __uint32_t xlog_tid_t; /* transaction ID type */

This should be in the patch introducing xfs_log_get_trans_ident.