Re: [PATCH 09/12] xfs: Introduce delayed logging core code

Alex Elder
2010-05-21T21:03:45Z

On Tue, 2010-05-18 at 09:24 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The delayed logging code only changes in-memory structures and as
> such can be enabled and disabled with a mount option. Add the mount
> option and emit a warning that this is an experimental feature that
> should not be used in production yet.

I gave this a careful review. I am a little surprised at
how nicely you could stitch this in, leveraging the existing
code, while still supporting the "old" logging model.

Anyway, I found some nits but no bugs so I'm not going
to bother mentioning them here.

Reviewed-by: Alex Elder <aelder@sgi.com>

. . .

> the necessary synchronisation for correct operation in both cases.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---