From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 04/12] xfs: Clean up XFS_BLI_* flag namespace
Date: Wed, 19 May 2010 14:09:16 -0500 [thread overview]
Message-ID: <1274296156.2140.51.camel@doink> (raw)
In-Reply-To: <1274138668-1662-5-git-send-email-david@fromorbit.com>
On Tue, 2010-05-18 at 09:24 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Clean up the buffer log format (XFS_BLI_*) flags because they have a
> polluted namespace. They XFS_BLI_ prefix is used for both in-memory
> and on-disk flag feilds, but have overlapping values for different
> flags. Rename the buffer log format flags to use the XFS_BLF_*
> prefix to avoid confusing them with the in-memory XFS_BLI_* prefixed
> flags.
This is a good change. That XFS_BLI_INODE_BUF thing was nasty.
One little comment below, but otherwise looks good.
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/linux-2.6/xfs_super.c | 2 +-
> fs/xfs/quota/xfs_dquot.c | 6 ++--
. . .
> diff --git a/fs/xfs/xfs_buf_item.h b/fs/xfs/xfs_buf_item.h
> index df44545..8cbb82b 100644
> --- a/fs/xfs/xfs_buf_item.h
> +++ b/fs/xfs/xfs_buf_item.h
> @@ -41,22 +41,22 @@ typedef struct xfs_buf_log_format {
> * This flag indicates that the buffer contains on disk inodes
> * and requires special recovery handling.
> */
> -#define XFS_BLI_INODE_BUF 0x1
> +#define XFS_BLF_INODE_BUF 0x1
> /*
> * This flag indicates that the buffer should not be replayed
> * during recovery because its blocks are being freed.
> */
> -#define XFS_BLI_CANCEL 0x2
> +#define XFS_BLF_CANCEL 0x2
> /*
> * This flag indicates that the buffer contains on disk
> * user or group dquots and may require special recovery handling.
> */
> -#define XFS_BLI_UDQUOT_BUF 0x4
> -#define XFS_BLI_PDQUOT_BUF 0x8
> -#define XFS_BLI_GDQUOT_BUF 0x10
> +#define XFS_BLF_UDQUOT_BUF 0x4
> +#define XFS_BLF_PDQUOT_BUF 0x8
> +#define XFS_BLF_GDQUOT_BUF 0x10
I know this isn't part of your change, but I think
a small comment here would make it more obvious
that the following are numeric values, distinct
from the bits defined just above (and therefore
not part of the same name space for flags).
Not a big deal--I'll make a note of it and may
do it myself someday.
> -#define XFS_BLI_CHUNK 128
> -#define XFS_BLI_SHIFT 7
> +#define XFS_BLF_CHUNK 128
> +#define XFS_BLF_SHIFT 7
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-05-19 19:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 23:24 [PATCH 0/12] xfs: delayed logging V6 Dave Chinner
2010-05-17 23:24 ` [PATCH 01/12] xfs: Don't reuse the same transaction ID for duplicated transactions Dave Chinner
2010-05-17 23:24 ` [PATCH 02/12] xfs: allow log ticket allocation to take allocation flags Dave Chinner
2010-05-17 23:24 ` [PATCH 03/12] xfs: modify buffer item reference counting Dave Chinner
2010-05-19 18:35 ` Alex Elder
2010-05-19 22:37 ` Dave Chinner
2010-05-17 23:24 ` [PATCH 04/12] xfs: Clean up XFS_BLI_* flag namespace Dave Chinner
2010-05-19 19:09 ` Alex Elder [this message]
2010-05-17 23:24 ` [PATCH 05/12] xfs: clean up log ticket overrun debug output Dave Chinner
2010-05-19 19:16 ` Alex Elder
2010-05-19 22:41 ` Dave Chinner
2010-05-17 23:24 ` [PATCH 06/12] xfs: make the log ticket ID available outside the log infrastructure Dave Chinner
2010-05-17 23:24 ` [PATCH 07/12] xfs: Improve scalability of busy extent tracking Dave Chinner
2010-05-20 20:15 ` Alex Elder
2010-05-21 2:16 ` Dave Chinner
2010-05-21 20:59 ` Alex Elder
2010-05-17 23:24 ` [PATCH 08/12] xfs: Delayed logging design documentation Dave Chinner
2010-05-21 21:02 ` Alex Elder
2010-05-17 23:24 ` [PATCH 09/12] xfs: Introduce delayed logging core code Dave Chinner
2010-05-21 21:06 ` Alex Elder
2010-05-17 23:24 ` [PATCH 10/12] xfs: forced unmounts need to push the CIL Dave Chinner
2010-05-17 23:24 ` [PATCH 11/12] xfs: enable background pushing of " Dave Chinner
2010-05-17 23:24 ` [PATCH 12/12] xfs: Ensure inode allocation buffers are fully replayed Dave Chinner
2010-05-21 21:21 ` [PATCH 0/12] xfs: delayed logging V6 Alex Elder
2010-05-22 0:39 ` Dave Chinner
2010-05-24 0:30 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2010-05-07 5:40 [PATCH 0/12] xfs: delayed logging V5 Dave Chinner
2010-05-07 5:40 ` [PATCH 04/12] xfs: Clean up XFS_BLI_* flag namespace Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274296156.2140.51.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox