From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 05/12] xfs: clean up log ticket overrun debug output
Date: Wed, 19 May 2010 14:16:44 -0500 [thread overview]
Message-ID: <1274296604.2140.55.camel@doink> (raw)
In-Reply-To: <1274138668-1662-6-git-send-email-david@fromorbit.com>
On Tue, 2010-05-18 at 09:24 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Push the error message output when a ticket overrun is detected
> into the ticket printing functions. Also remove the debug version
> of the code as the production version will still panic just as
> effectively on a debug kernel via the panic mask being set.
Another not-really-actionable bit of commentary
below, but this looks good.
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_error.c | 2 +-
> fs/xfs/xfs_log.c | 19 +++++--------------
> 2 files changed, 6 insertions(+), 15 deletions(-)
>
> diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
> index ef96175..047b8a8 100644
> --- a/fs/xfs/xfs_error.c
> +++ b/fs/xfs/xfs_error.c
> @@ -170,7 +170,7 @@ xfs_cmn_err(int panic_tag, int level, xfs_mount_t *mp, char *fmt, ...)
> va_list ap;
>
> #ifdef DEBUG
> - xfs_panic_mask |= XFS_PTAG_SHUTDOWN_CORRUPT;
> + xfs_panic_mask |= (XFS_PTAG_SHUTDOWN_CORRUPT | XFS_PTAG_LOGRES);
> #endif
>
> if (xfs_panic_mask && (xfs_panic_mask & panic_tag)
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 83be6a6..1efb303 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1645,6 +1645,10 @@ xlog_print_tic_res(xfs_mount_t *mp, xlog_ticket_t *ticket)
> "bad-rtype" : res_type_str[r_type-1]),
> ticket->t_res_arr[i].r_len);
> }
> +
> + xfs_cmn_err(XFS_PTAG_LOGRES, CE_ALERT, mp,
> + "xfs_log_write: reservation ran out. Need to up reservation");
> + xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_INCORE);
> }
>
> /*
> @@ -1897,21 +1901,8 @@ xlog_write(
> *start_lsn = 0;
>
> len = xlog_write_calc_vec_length(ticket, log_vector);
> - if (ticket->t_curr_res < len) {
> + if (ticket->t_curr_res < len)
> xlog_print_tic_res(log->l_mp, ticket);
Somehow "xlog_print_tic_res" doesn't suggest to me
that we're going to panic at this point, and I think
therefore that bit of information is lost with this
change. I prefer what you've done, but I think I
would have liked some brief comment or something that
tells me this is a fatal condition.
> -#ifdef DEBUG
> - xlog_panic(
> - "xfs_log_write: reservation ran out. Need to up reservation");
> -#else
> - /* Customer configurable panic */
> - xfs_cmn_err(XFS_PTAG_LOGRES, CE_ALERT, log->l_mp,
> - "xfs_log_write: reservation ran out. Need to up reservation");
> -
> - /* If we did not panic, shutdown the filesystem */
> - xfs_force_shutdown(log->l_mp, SHUTDOWN_CORRUPT_INCORE);
> -#endif
> - }
> -
> ticket->t_curr_res -= len;
>
> index = 0;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-05-19 19:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 23:24 [PATCH 0/12] xfs: delayed logging V6 Dave Chinner
2010-05-17 23:24 ` [PATCH 01/12] xfs: Don't reuse the same transaction ID for duplicated transactions Dave Chinner
2010-05-17 23:24 ` [PATCH 02/12] xfs: allow log ticket allocation to take allocation flags Dave Chinner
2010-05-17 23:24 ` [PATCH 03/12] xfs: modify buffer item reference counting Dave Chinner
2010-05-19 18:35 ` Alex Elder
2010-05-19 22:37 ` Dave Chinner
2010-05-17 23:24 ` [PATCH 04/12] xfs: Clean up XFS_BLI_* flag namespace Dave Chinner
2010-05-19 19:09 ` Alex Elder
2010-05-17 23:24 ` [PATCH 05/12] xfs: clean up log ticket overrun debug output Dave Chinner
2010-05-19 19:16 ` Alex Elder [this message]
2010-05-19 22:41 ` Dave Chinner
2010-05-17 23:24 ` [PATCH 06/12] xfs: make the log ticket ID available outside the log infrastructure Dave Chinner
2010-05-17 23:24 ` [PATCH 07/12] xfs: Improve scalability of busy extent tracking Dave Chinner
2010-05-20 20:15 ` Alex Elder
2010-05-21 2:16 ` Dave Chinner
2010-05-21 20:59 ` Alex Elder
2010-05-17 23:24 ` [PATCH 08/12] xfs: Delayed logging design documentation Dave Chinner
2010-05-21 21:02 ` Alex Elder
2010-05-17 23:24 ` [PATCH 09/12] xfs: Introduce delayed logging core code Dave Chinner
2010-05-21 21:06 ` Alex Elder
2010-05-17 23:24 ` [PATCH 10/12] xfs: forced unmounts need to push the CIL Dave Chinner
2010-05-17 23:24 ` [PATCH 11/12] xfs: enable background pushing of " Dave Chinner
2010-05-17 23:24 ` [PATCH 12/12] xfs: Ensure inode allocation buffers are fully replayed Dave Chinner
2010-05-21 21:21 ` [PATCH 0/12] xfs: delayed logging V6 Alex Elder
2010-05-22 0:39 ` Dave Chinner
2010-05-24 0:30 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2010-05-07 5:40 [PATCH 0/12] xfs: delayed logging V5 Dave Chinner
2010-05-07 5:40 ` [PATCH 05/12] xfs: clean up log ticket overrun debug output Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274296604.2140.55.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox