public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: xfs@oss.sgi.com
Cc: hch@infradead.org, Jan Kara <jack@suse.cz>
Subject: [PATCH 2/8] Fix fallocate() test
Date: Mon, 24 May 2010 16:14:13 +0200	[thread overview]
Message-ID: <1274710459-11446-3-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1274710459-11446-1-git-send-email-jack@suse.cz>

The test for fallocate was broken because it used $TEST_DIR/$tmp.io. Because
$tmp is usually something like /tmp/1234 or /mnt/1234 the file cannot be
created and xfs_io fails regardless of existance of fallocate support. Moreover
the subsequent message parsing decides that fallocate is actually supported
because it does not expect this message.

Fix the test to not use $tmp.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 common.rc |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/common.rc b/common.rc
index e6d818d..6bf1e12 100644
--- a/common.rc
+++ b/common.rc
@@ -803,8 +803,9 @@ _require_user()
 #
 _require_xfs_io_falloc()
 {
-	testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $TEST_DIR/$tmp.io 2>&1`
-	rm -f $TEST_DIR/$tmp.io 2>&1 > /dev/null
+	testfile=$TEST_DIR/$$.falloc
+	testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1`
+	rm -f $testfile 2>&1 > /dev/null
 	echo $testio | grep -q "not found" && \
 		_notrun "xfs_io fallocate support is missing"
 	echo $testio | grep -q "Operation not supported" && \
-- 
1.6.4.2

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2010-05-24 14:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24 14:14 [PATCH 0/8 v3] Quota tests for XFSQA Jan Kara
2010-05-24 14:14 ` [PATCH 1/8] Fix test whether kernel supports quotas Jan Kara
2010-05-24 14:14 ` Jan Kara [this message]
2010-05-24 14:14 ` [PATCH 3/8] Test basic quota enforcement Jan Kara
2010-05-25 10:06   ` Christoph Hellwig
2010-05-25 14:41     ` Jan Kara
2010-05-25 20:39     ` Jan Kara
2010-05-27 16:30       ` Christoph Hellwig
2010-05-27 17:08         ` Jan Kara
2010-05-24 14:14 ` [PATCH 4/8] Add test of quota accounting using fsx Jan Kara
2010-06-09 17:49   ` Eric Sandeen
2010-06-10 10:58     ` Jan Kara
2010-06-10 16:50       ` Eric Sandeen
2010-06-10 20:43         ` Eric Sandeen
2010-06-14 12:46           ` Jan Kara
2010-06-14 10:48         ` Jan Kara
2010-06-15  9:55     ` Jan Kara
2010-07-26 21:46       ` Eric Sandeen
2010-07-27  8:15         ` Jan Kara
2010-07-27  8:48           ` Jan Kara
2010-07-27 13:11             ` Eric Sandeen
2010-05-24 14:14 ` [PATCH 5/8] Add quota test with fsstress Jan Kara
2010-05-24 14:14 ` [PATCH 6/8] Add quota accounting test when fsstress is run and quota limits are set low Jan Kara
2010-05-24 14:14 ` [PATCH 7/8] Add test of quota limit and info setting Jan Kara
2010-05-24 14:14 ` [PATCH 8/8] Add test for quota accounting after remount read only Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274710459-11446-3-git-send-email-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox