Re: [PATCH 3/6] ext4: Use our own write_cache_pages()

Dave Chinner
2010-05-25T22:40:54Z

On Tue, May 25, 2010 at 09:06:26AM -0400, tytso@mit.edu wrote:
> On Tue, May 25, 2010 at 08:54:09PM +1000, Dave Chinner wrote:
> > From: Theodore Ts'o <tytso@mit.edu>
> >
> > Make a copy of write_cache_pages() for the benefit of
> > ext4_da_writepages(). This allows us to simplify the code some, and
> > will allow us to further customize the code in future patches.
>
> I'm going to be pushing this to Linus shortly, so it's likely you'll
> be able to drop this from your patch series.

Great!

> I just wanted to give
> you a heads up about what I was planning on doing, which hopefully
> simplified your life a little.

And that's appreciated. I included it to make sure everyone could
see how this all fitted together and others could test it if they so
desired. i.e. make sure I wasn't breaking ext4 by reverting the
changes to write_cache_pages. I'll leave it in the series until the
ext4 change is upstream, then I'll drop it.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com