From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 00/17] pending patches
Date: Thu, 03 Jun 2010 12:01:46 -0500 [thread overview]
Message-ID: <1275584506.2468.57.camel@doink> (raw)
In-Reply-To: <20100531160727.842750532@bombadil.infradead.org>
On Mon, 2010-05-31 at 12:07 -0400, Christoph Hellwig wrote:
> Here's my list of pending patches. Ordering them is getting a bit
> difficult as various patches that have been out of a while haven't
> been commited yet. Note that some patches require Dave's
>
> [PATCH] xfs: fix race in inode cluster freeing failing to stale inodes
>
> applies first. That patch is a clear candidate for something that
> should go to Linus ASAP IHMO.
I agree it should go into 2.6.35. Last I saw on that one, Dave
said he was going to update it, so I was waiting for that. I
now see it's available on his kernel.org tree so I can grab
that and get it in the pipeline to send to Linus soon.
I mentioned to you privately a few weeks ago that I had some concerns
about removing DMAPI support, and had promised to send a note out to
the list to that effect, but regretfully I never did that.
I would like to have a chance to submit an alternative to simply
removing that code. I recognize it sits in the first part of your
patch series, and I will gladly do the work to rearrange them to
put it at the end, in order to give me some time to develop my
proposed change.
Basically what I'd like to do is update the DMAPI support code
so that it is much better isolated. I would like to replace
the big ugly hunks that lie in common code paths with small
function calls, so that their footprint is minimal and not
distracting (along the lines of tracing calls).
I got a start on doing this, and had hoped to send the result
pretty soon after your initial posting of the patch, but that
work unfortunately got preempted by other more pressing stuff.
I wanted to provide actual code to help make the discussion
of the merits of removal versus cleanup more concrete. I
now think I'll be able to put something together within the
next week or so.
I'll wait to hear back from you and others. In the mean time
I'll make my way through the rest of the patch series.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-06-03 16:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 16:07 [PATCH 00/17] pending patches Christoph Hellwig
2010-05-31 16:07 ` [PATCH 01/17] xfs: remove done roadmap item from xfs-delayed-logging-design.txt Christoph Hellwig
2010-06-02 4:33 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 02/17] xfs: skip writeback from reclaim context Christoph Hellwig
2010-06-02 4:39 ` Dave Chinner
2010-06-02 10:08 ` Christoph Hellwig
2010-06-02 23:02 ` Dave Chinner
2010-06-03 6:52 ` Christoph Hellwig
2010-05-31 16:07 ` [PATCH 03/17] xfs: improve xfs_isilocked Christoph Hellwig
2010-06-02 4:41 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 04/17] xfs: drop dmapi hooks Christoph Hellwig
2010-06-02 4:45 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 05/17] xfs: remove unneeded #include statements Christoph Hellwig
2010-06-02 4:45 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 06/17] xfs: simplify log item descriptor tracking Christoph Hellwig
2010-06-02 5:11 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 07/17] xfs: merge iop_unpin_remove into iop_unpin Christoph Hellwig
2010-06-02 5:14 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 08/17] xfs: give xfs_item_ops methods the correct prototypes Christoph Hellwig
2010-06-02 5:30 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 09/17] xfs: give li_cb callbacks the correct prototype Christoph Hellwig
2010-06-02 5:45 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 10/17] xfs: simplify buffer pinning Christoph Hellwig
2010-06-02 5:47 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 11/17] xfs: simplify inode to transaction joining Christoph Hellwig
2010-06-02 5:57 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 12/17] xfs: fix the xfs_log_iovec i_addr type Christoph Hellwig
2010-06-02 6:01 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 13/17] xfs: kill the unused xlog_debug variable Christoph Hellwig
2010-06-02 6:02 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 14/17] xfs: remove the unused XFS_LOG_SLEEP and XFS_LOG_NOSLEEP flags Christoph Hellwig
2010-06-02 6:02 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 15/17] xfs: remove the unused XFS_TRANS_NOSLEEP/XFS_TRANS_WAIT flags Christoph Hellwig
2010-06-02 6:03 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 16/17] xfs: remove unused XFS_BMAPI_ flags Christoph Hellwig
2010-06-02 6:04 ` Dave Chinner
2010-05-31 16:07 ` [PATCH 17/17] xfs: remove unused delta tracking code in xfs_bmapi Christoph Hellwig
2010-06-02 6:11 ` Dave Chinner
2010-06-02 6:13 ` [PATCH 00/17] pending patches Dave Chinner
2010-06-03 17:01 ` Alex Elder [this message]
2010-06-03 17:08 ` dropping dmapi support, was " Christoph Hellwig
2010-06-03 22:33 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275584506.2468.57.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox