From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 03/15] xfs: move DMAPI definitions out of "xfs_mount.h"
Date: Fri, 02 Jul 2010 14:50:02 -0500 [thread overview]
Message-ID: <1278100202.1876.120.camel@doink> (raw)
In-Reply-To: <20100629133500.GA11312@infradead.org>
On Tue, 2010-06-29 at 09:35 -0400, Christoph Hellwig wrote:
> On Mon, Jun 28, 2010 at 05:04:52PM -0500, Alex Elder wrote:
> > XFS defines a bunch of DMAPI cruft in xfs_mount.h. There is no need
> > for it to be there; move it instead into the xfs_dmapi.h file. A
> > side-effect of this is that "xfs_dmapi.h" now depends on and needs
> > to be #included after "xfs_mount.h" and "xfs_inode.h" (the latter of
> > which itself depends on a "xfs_bmap_btree.h").
> >
> > On the other hand, "xfs_dmapi.h" is #included by a LOT more files
> > than it needs to be, so eliminate those cases.
> >
> > Finally, "xfs_inode.h" defines a type dm_attrs_t that is never
> > referenced anywhere else, so kill it off.
>
> Asserting copyright on removing single include lines seems rather
> interesting..
I simply updated the copyright on every file I touched.
We've been advised that "SGI" is the new description
of the company in copyright statements, so I was just
doing a blanket update.
I'll keep those changes, but will drop the ones where I
actually added a copyright that wasn't there before.
Looks like only one of the 64 files changed fits that
description ("linux-2.6/xfs_quotaops.c").
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-07-02 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 22:04 [PATCH 03/15] xfs: move DMAPI definitions out of "xfs_mount.h" Alex Elder
2010-06-29 13:35 ` Christoph Hellwig
2010-07-02 19:50 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278100202.1876.120.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox