From: Lukas Czerner <lczerner@redhat.com>
To: xfs@oss.sgi.com
Cc: lczerner@redhat.com, esandeen@redhat.com
Subject: [PATCH 1/2] Allow to specify unsupported file systems
Date: Thu, 8 Jul 2010 17:23:51 +0200 [thread overview]
Message-ID: <1278602632-12425-1-git-send-email-lczerner@redhat.com> (raw)
As an addition to checking for supported file systems it would be nice
to be able to specify unsupported file system. In combination with
"generic" fs it can be useful. This patch adds that feature. For example
to set ext3 as an unsupported fs add "!ext3" into list.
Also specify ext3 and ex4 as unsupported file systems in 213 and 214
since those fs does not support fallocate. There may be others though.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
213 | 2 +-
214 | 2 +-
common.rc | 22 +++++++++++++++++-----
3 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/213 b/213
index 9982dd4..3e90c0a 100755
--- a/213
+++ b/213
@@ -47,7 +47,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
# real QA test starts here
# generic, but xfs_io's fallocate must work
-_supported_fs generic
+_supported_fs generic !ext3 !ext3
# only Linux supports fallocate
_supported_os Linux
diff --git a/214 b/214
index cef7626..c01ef30 100755
--- a/214
+++ b/214
@@ -45,7 +45,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
# real QA test starts here
# generic, but xfs_io's fallocate must work
-_supported_fs generic
+_supported_fs generic !ext3 !ext2
# only Linux supports fallocate
_supported_os Linux
diff --git a/common.rc b/common.rc
index 6bf1e12..f2f4cc3 100644
--- a/common.rc
+++ b/common.rc
@@ -656,15 +656,27 @@ _fail()
#
_supported_fs()
{
+ supp=0
for f
do
- if [ "$f" = "$FSTYP" -o "$f" = "generic" ]
- then
- return
- fi
+ if [ "$f" = \!"$FSTYP" ]
+ then
+ supp=0
+ break
+ fi
+
+ if [ "$f" = "$FSTYP" -o "$f" = "generic" ]
+ then
+ supp=1
+ fi
done
- _notrun "not suitable for this filesystem type: $FSTYP"
+ if [ $supp -eq 1 ]
+ then
+ return
+ else
+ _notrun "not suitable for this filesystem type: $FSTYP"
+ fi
}
# tests whether $FSTYP is one of the supported OSes for a test
--
1.7.1.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-07-08 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 15:23 Lukas Czerner [this message]
2010-07-08 15:23 ` [PATCH 2/2] Show duration of current test Lukas Czerner
2010-07-09 13:21 ` Alex Elder
2010-07-09 13:14 ` [PATCH 1/2] Allow to specify unsupported file systems Alex Elder
2010-07-09 13:28 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278602632-12425-1-git-send-email-lczerner@redhat.com \
--to=lczerner@redhat.com \
--cc=esandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox