From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfsprogs: only absolute run-paths are allowed
Date: Wed, 21 Jul 2010 13:33:22 -0500 [thread overview]
Message-ID: <1279737202.1816.16.camel@doink> (raw)
In-Reply-To: <20100721171319.GA17772@infradead.org>
On Wed, 2010-07-21 at 13:13 -0400, Christoph Hellwig wrote:
> On Wed, Jul 21, 2010 at 04:31:01AM -0700, Christian Kujau wrote:
> > Hi,
> >
> > I noticed that I can't use --prefix= any more for the ./configure script.
> > Doing so makes libtool unhappy:
> >
> > $ make configure
> > $ ./configure --prefix=/opt/xfsprogs
> > $ make
> > [...]
> > libtool: link: only absolute run-paths are allowed
> > make[2]: *** [libxfs.la] Error 1
>
> The patch below should fix this issue. Note that you need to do a
>
> make realclean
> make configure
>
> to regenerate the configure script first.
This looks OK to me. Once you get confirmation
it works for Christian you can re-format your
description and commit it. (I didn't see the
problem in my environment for some reason.)
Reviewed-by: Alex Elder <aelder@sgi.com>
> Index: xfsprogs-dev/configure.in
> ===================================================================
> --- xfsprogs-dev.orig/configure.in 2010-07-21 19:03:45.225494681 +0200
> +++ xfsprogs-dev/configure.in 2010-07-21 19:06:19.649494682 +0200
> @@ -65,12 +65,17 @@ esac
> case $exec_prefix:$prefix in
> NONE:NONE | NONE:/usr | /usr:*)
> root_sbindir='/sbin'
> - AC_SUBST([root_sbindir])
> -
> root_libdir="/${base_libdir}"
> - AC_SUBST([root_libdir])
> + ;;
> +*)
> + root_sbindir="${sbindir}"
> + root_libdir="${libdir}"
> + ;;
> esac
>
> +AC_SUBST([root_sbindir])
> +AC_SUBST([root_libdir])
> +
> # Find localized files
> LOCALIZED_FILES=""
> for lfile in `find ${srcdir} -name '*.c' -type f || exit 1`; do
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-21 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 11:31 xfsprogs: only absolute run-paths are allowed Christian Kujau
2010-07-21 17:13 ` Christoph Hellwig
2010-07-21 18:33 ` Alex Elder [this message]
2010-07-21 18:55 ` Christian Kujau
2010-07-21 19:10 ` Alex Elder
2010-07-22 5:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279737202.1816.16.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox