* xfsprogs: only absolute run-paths are allowed
@ 2010-07-21 11:31 Christian Kujau
2010-07-21 17:13 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Christian Kujau @ 2010-07-21 11:31 UTC (permalink / raw)
To: xfs
Hi,
I noticed that I can't use --prefix= any more for the ./configure script.
Doing so makes libtool unhappy:
$ make configure
$ ./configure --prefix=/opt/xfsprogs
$ make
[...]
libtool: link: only absolute run-paths are allowed
make[2]: *** [libxfs.la] Error 1
Digging through the releases I noticed that using --prefix= was possible
with v3.0.4 but fails with v3.0.5, more exactly commit 595e27 seems to be
the changeset in question, as reverting it helps:
commit 595e27dbd7360e81fa9e74d992098fe44fd7aed5
Author: Christoph Hellwig <hch@lst.de>
Date: Sat Oct 10 17:02:53 2009 -0400
update configure defaults
So, I guess my question is: how can I build xfsprogs to install in a
different location?
Full buildlogs: http://nerdbynature.de/bits/xfsprogs/prefix/
Thanks,
Christian.
--
BOFH excuse #94:
Internet outage
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: xfsprogs: only absolute run-paths are allowed
2010-07-21 11:31 xfsprogs: only absolute run-paths are allowed Christian Kujau
@ 2010-07-21 17:13 ` Christoph Hellwig
2010-07-21 18:33 ` Alex Elder
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2010-07-21 17:13 UTC (permalink / raw)
To: Christian Kujau; +Cc: xfs
On Wed, Jul 21, 2010 at 04:31:01AM -0700, Christian Kujau wrote:
> Hi,
>
> I noticed that I can't use --prefix= any more for the ./configure script.
> Doing so makes libtool unhappy:
>
> $ make configure
> $ ./configure --prefix=/opt/xfsprogs
> $ make
> [...]
> libtool: link: only absolute run-paths are allowed
> make[2]: *** [libxfs.la] Error 1
The patch below should fix this issue. Note that you need to do a
make realclean
make configure
to regenerate the configure script first.
Index: xfsprogs-dev/configure.in
===================================================================
--- xfsprogs-dev.orig/configure.in 2010-07-21 19:03:45.225494681 +0200
+++ xfsprogs-dev/configure.in 2010-07-21 19:06:19.649494682 +0200
@@ -65,12 +65,17 @@ esac
case $exec_prefix:$prefix in
NONE:NONE | NONE:/usr | /usr:*)
root_sbindir='/sbin'
- AC_SUBST([root_sbindir])
-
root_libdir="/${base_libdir}"
- AC_SUBST([root_libdir])
+ ;;
+*)
+ root_sbindir="${sbindir}"
+ root_libdir="${libdir}"
+ ;;
esac
+AC_SUBST([root_sbindir])
+AC_SUBST([root_libdir])
+
# Find localized files
LOCALIZED_FILES=""
for lfile in `find ${srcdir} -name '*.c' -type f || exit 1`; do
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: xfsprogs: only absolute run-paths are allowed
2010-07-21 17:13 ` Christoph Hellwig
@ 2010-07-21 18:33 ` Alex Elder
2010-07-21 18:55 ` Christian Kujau
0 siblings, 1 reply; 6+ messages in thread
From: Alex Elder @ 2010-07-21 18:33 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Wed, 2010-07-21 at 13:13 -0400, Christoph Hellwig wrote:
> On Wed, Jul 21, 2010 at 04:31:01AM -0700, Christian Kujau wrote:
> > Hi,
> >
> > I noticed that I can't use --prefix= any more for the ./configure script.
> > Doing so makes libtool unhappy:
> >
> > $ make configure
> > $ ./configure --prefix=/opt/xfsprogs
> > $ make
> > [...]
> > libtool: link: only absolute run-paths are allowed
> > make[2]: *** [libxfs.la] Error 1
>
> The patch below should fix this issue. Note that you need to do a
>
> make realclean
> make configure
>
> to regenerate the configure script first.
This looks OK to me. Once you get confirmation
it works for Christian you can re-format your
description and commit it. (I didn't see the
problem in my environment for some reason.)
Reviewed-by: Alex Elder <aelder@sgi.com>
> Index: xfsprogs-dev/configure.in
> ===================================================================
> --- xfsprogs-dev.orig/configure.in 2010-07-21 19:03:45.225494681 +0200
> +++ xfsprogs-dev/configure.in 2010-07-21 19:06:19.649494682 +0200
> @@ -65,12 +65,17 @@ esac
> case $exec_prefix:$prefix in
> NONE:NONE | NONE:/usr | /usr:*)
> root_sbindir='/sbin'
> - AC_SUBST([root_sbindir])
> -
> root_libdir="/${base_libdir}"
> - AC_SUBST([root_libdir])
> + ;;
> +*)
> + root_sbindir="${sbindir}"
> + root_libdir="${libdir}"
> + ;;
> esac
>
> +AC_SUBST([root_sbindir])
> +AC_SUBST([root_libdir])
> +
> # Find localized files
> LOCALIZED_FILES=""
> for lfile in `find ${srcdir} -name '*.c' -type f || exit 1`; do
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: xfsprogs: only absolute run-paths are allowed
2010-07-21 18:33 ` Alex Elder
@ 2010-07-21 18:55 ` Christian Kujau
2010-07-21 19:10 ` Alex Elder
2010-07-22 5:22 ` Christoph Hellwig
0 siblings, 2 replies; 6+ messages in thread
From: Christian Kujau @ 2010-07-21 18:55 UTC (permalink / raw)
To: Alex Elder; +Cc: Christoph Hellwig, xfs
On Wed, 21 Jul 2010 at 13:33, Alex Elder wrote:
> > The patch below should fix this issue. Note that you need to do a
> >
> > make realclean
> > make configure
> >
> > to regenerate the configure script first.
>
> This looks OK to me. Once you get confirmation
> it works for Christian you can re-format your
> description and commit it. (I didn't see the
> problem in my environment for some reason.)
Yes, the patch works for me, thanks Christoph!
Tested-by: Christian Kujau <lists@nerdbynature.de>
Btw, I noticed quite a few warnings[0] during compilation:
warning: pointer targets in assignment differ in signedness
warning: pointer targets in passing argument 1 of '...' differ in signedness
I hope they're nothing to worry about?
Thanks again,
Christian.
[0] http://nerdbynature.de/bits/xfsprogs/prefix/make_v3.1.2.log.gz
--
BOFH excuse #260:
We're upgrading /dev/null
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: xfsprogs: only absolute run-paths are allowed
2010-07-21 18:55 ` Christian Kujau
@ 2010-07-21 19:10 ` Alex Elder
2010-07-22 5:22 ` Christoph Hellwig
1 sibling, 0 replies; 6+ messages in thread
From: Alex Elder @ 2010-07-21 19:10 UTC (permalink / raw)
To: Christian Kujau; +Cc: Christoph Hellwig, xfs
On Wed, 2010-07-21 at 11:55 -0700, Christian Kujau wrote:
> On Wed, 21 Jul 2010 at 13:33, Alex Elder wrote:
> > > The patch below should fix this issue. Note that you need to do a
> > >
> > > make realclean
> > > make configure
> > >
> > > to regenerate the configure script first.
> >
> > This looks OK to me. Once you get confirmation
> > it works for Christian you can re-format your
> > description and commit it. (I didn't see the
> > problem in my environment for some reason.)
>
> Yes, the patch works for me, thanks Christoph!
>
> Tested-by: Christian Kujau <lists@nerdbynature.de>
>
> Btw, I noticed quite a few warnings[0] during compilation:
>
> warning: pointer targets in assignment differ in signedness
> warning: pointer targets in passing argument 1 of '...' differ in signedness
>
> I hope they're nothing to worry about?
Nothing to worry about. We need to update some
code but it some cases it needs to match the
kernel code as well. Eventually we'll get there.
-Alex
> Thanks again,
> Christian.
>
> [0] http://nerdbynature.de/bits/xfsprogs/prefix/make_v3.1.2.log.gz
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: xfsprogs: only absolute run-paths are allowed
2010-07-21 18:55 ` Christian Kujau
2010-07-21 19:10 ` Alex Elder
@ 2010-07-22 5:22 ` Christoph Hellwig
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2010-07-22 5:22 UTC (permalink / raw)
To: Christian Kujau; +Cc: xfs, Alex Elder
I've applied that patch now both to xfsprogs and xfsdump which had
the exact same issue.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-22 5:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-21 11:31 xfsprogs: only absolute run-paths are allowed Christian Kujau
2010-07-21 17:13 ` Christoph Hellwig
2010-07-21 18:33 ` Alex Elder
2010-07-21 18:55 ` Christian Kujau
2010-07-21 19:10 ` Alex Elder
2010-07-22 5:22 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox