From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Cc: npiggin@kernel.de
Subject: [PATCH 0/2] xfs: fix bugs uncovered by dbench testing
Date: Fri, 30 Jul 2010 08:55:44 +1000 [thread overview]
Message-ID: <1280444146-14540-1-git-send-email-david@fromorbit.com> (raw)
The reproducer Nick found that hung the XFS filesystem has two
different causes. Both manifest in the same way, so it was difficult to tell
them aparṫ - they left an item that could notbe flushed stuck in the AIL and
hence preventing the tail of the log from being moved forward.
The most frequently tripped problem (generally within 5 minutes) was the CIL
commit race when the checkpoitn could commit before the transaction items were
unlocked, resulting in stale information in log items and incorrect processing
of stale buffers. I coul dnot reproduce this race condition with a debug
kernel, which explain why my previous dbench testing did not uncover it.
Less frequently tripped was the inode cluster freeing problem - it would take
around 2 hours on average to trip this one, and it does not require delayed
logging to hit.
Nick, you'll need both patches to avoid the the hangs you reported - I've had
your test case running now for just over ten hours without any issues so far.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-06-08 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 22:55 Dave Chinner [this message]
2010-07-29 22:55 ` [PATCH 1/2] xfs: unlock items before allowing the CIL to commit Dave Chinner
2010-07-30 8:49 ` Christoph Hellwig
2010-07-29 22:55 ` [PATCH 2/2] xfs: ensure we mark all inodes in a freed cluster XFS_ISTALE Dave Chinner
2010-07-30 10:27 ` Christoph Hellwig
2010-07-30 10:54 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280444146-14540-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=npiggin@kernel.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox