From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] xfs: kill XBF_FS_MANAGED buffers
Date: Fri, 10 Sep 2010 16:17:45 -0500 [thread overview]
Message-ID: <1284153465.2468.20.camel@doink> (raw)
In-Reply-To: <1283958778-28610-2-git-send-email-david@fromorbit.com>
On Thu, 2010-09-09 at 01:12 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Filesystem level managed buffers are buffers that have their
> lifecycle controlled by the filesystem layer, not the buffer cache.
> We currently hash these buffers, which makes cleanup and hash
> walking somewhat troublesome. Convert the fs managed buffers to
> unhashed buffers obtained by via xfs_buf_get_noaddr(), and remove the
> XBF_FS_MANAGED special cases from the buffer cache.
I've looked this over and it looks good to me.
I agree with all of Christoph's comments from
the other day. I'll look for your update.
-Alex
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
. . .
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-09-10 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 15:12 [RFC] [PATCH 0/4] Replace buffer cache hash with rbtrees Dave Chinner
2010-09-08 15:12 ` [PATCH 1/4] xfs: kill XBF_FS_MANAGED buffers Dave Chinner
2010-09-09 1:33 ` Christoph Hellwig
2010-09-10 3:10 ` Dave Chinner
2010-09-10 21:17 ` Alex Elder [this message]
2010-09-08 15:12 ` [PATCH 2/4] xfs: use unhashed buffers for size checks Dave Chinner
2010-09-09 1:38 ` Christoph Hellwig
2010-09-10 3:14 ` Dave Chinner
2010-09-10 21:33 ` Alex Elder
2010-09-08 15:12 ` [PATCH 3/4] xfs: remove buftarg hash for external devices Dave Chinner
2010-09-09 1:39 ` Christoph Hellwig
2010-09-08 15:12 ` [PATCH 4/4] xfs: convert buffer cache hash to rbtree Dave Chinner
2010-09-09 1:51 ` Christoph Hellwig
2010-09-10 3:22 ` Dave Chinner
2010-09-13 16:59 ` Alex Elder
2010-09-13 16:53 ` Alex Elder
2010-09-14 7:13 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284153465.2468.20.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox