From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o8ALZ3wD166220 for ; Fri, 10 Sep 2010 16:35:03 -0500 Subject: Re: [PATCH 2/4] xfs: use unhashed buffers for size checks From: Alex Elder In-Reply-To: <1283958778-28610-3-git-send-email-david@fromorbit.com> References: <1283958778-28610-1-git-send-email-david@fromorbit.com> <1283958778-28610-3-git-send-email-david@fromorbit.com> Date: Fri, 10 Sep 2010 16:33:57 -0500 Message-ID: <1284154437.2468.34.camel@doink> Mime-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Thu, 2010-09-09 at 01:12 +1000, Dave Chinner wrote: > From: Dave Chinner > > When we are checking we can access the last block of each device, we > do not need to use hashed buffers as they will be tossed away > immediately. Use unhashed buffers for size checks so that all IO > prior to full in-memory structure initialisation does not use the > buffer cache hashes. This one also looks good, and again I agree with the comments Christoph made. I'll look for your update. Patch 3 in the series is good too; I'll look at the last patch (the switch to rbtrees) over the weekend. > Signed-off-by: Dave Chinner _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs