From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] xfs: convert buffer cache hash to rbtree
Date: Mon, 13 Sep 2010 11:59:45 -0500 [thread overview]
Message-ID: <1284397185.2404.54.camel@doink> (raw)
In-Reply-To: <20100909015150.GB11362@infradead.org>
> > @@ -210,8 +210,6 @@ xfs_perag_get(struct xfs_mount *mp, xfs_agnumber_t agno)
> > pag = radix_tree_lookup(&mp->m_perag_tree, agno);
> > if (pag) {
> > ASSERT(atomic_read(&pag->pag_ref) >= 0);
> > - /* catch leaks in the positive direction during testing */
> > - ASSERT(atomic_read(&pag->pag_ref) < 1000);
>
> Di you manage to hit this during testing? Either way it should probably
> be a separate patch.
I'm pretty sure this is due to each buffer now holding
a perag reference. It might be nice to preserve this
functionality by checking against the number of blocks
in the AG or something similar. But it's debug so it's
not quite as critical.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-09-13 16:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 15:12 [RFC] [PATCH 0/4] Replace buffer cache hash with rbtrees Dave Chinner
2010-09-08 15:12 ` [PATCH 1/4] xfs: kill XBF_FS_MANAGED buffers Dave Chinner
2010-09-09 1:33 ` Christoph Hellwig
2010-09-10 3:10 ` Dave Chinner
2010-09-10 21:17 ` Alex Elder
2010-09-08 15:12 ` [PATCH 2/4] xfs: use unhashed buffers for size checks Dave Chinner
2010-09-09 1:38 ` Christoph Hellwig
2010-09-10 3:14 ` Dave Chinner
2010-09-10 21:33 ` Alex Elder
2010-09-08 15:12 ` [PATCH 3/4] xfs: remove buftarg hash for external devices Dave Chinner
2010-09-09 1:39 ` Christoph Hellwig
2010-09-08 15:12 ` [PATCH 4/4] xfs: convert buffer cache hash to rbtree Dave Chinner
2010-09-09 1:51 ` Christoph Hellwig
2010-09-10 3:22 ` Dave Chinner
2010-09-13 16:59 ` Alex Elder [this message]
2010-09-13 16:53 ` Alex Elder
2010-09-14 7:13 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284397185.2404.54.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox