From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o8EHKkqS137989 for ; Tue, 14 Sep 2010 12:20:46 -0500 Subject: Re: [PATCH 02/18] xfs: reduce the number of CIL lock round trips during commit From: Alex Elder In-Reply-To: <1284461777-1496-3-git-send-email-david@fromorbit.com> References: <1284461777-1496-1-git-send-email-david@fromorbit.com> <1284461777-1496-3-git-send-email-david@fromorbit.com> Date: Tue, 14 Sep 2010 12:21:22 -0500 Message-ID: <1284484882.2098.70.camel@doink> Mime-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, 2010-09-14 at 20:56 +1000, Dave Chinner wrote: > From: Dave Chinner > > When commiting a transaction, we do a lock CIL state lock round trip > on every single log vector we insert into the CIL. This is resulting > in the lock being as hot as the inode and dcache locks on 8-way > create workloads. Rework the insertion loops to bring the number > of lock round trips to one per transaction for log vectors, and one > more do the busy extents. > > Also change the allocation of the log vector buffer not to zero it > as we copy over the entire allocated buffer anyway. > Looks good. Reviewed-by: Alex Elder > Signed-off-by: Dave Chinner > --- > fs/xfs/xfs_log_cil.c | 116 +++++++++++++++++++++++++++++-------------------- > 1 files changed, 69 insertions(+), 47 deletions(-) _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs