Re: [PATCH 17/18] xfs: add a lru to the XFS buffer cache

Christoph Hellwig
2010-09-14T23:15:56Z

Looks correct to me, although probably indeed a bit simplistic.

> + /* add to LRU */
> + spin_lock(&btp->bt_lru_lock);
> + list_add_tail(&new_bp->b_lru, &btp->bt_lru);
> + btp->bt_lru_nr++;
> + atomic_inc(&new_bp->b_hold);
> + spin_unlock(&btp->bt_lru_lock);

Just for clarity it would be nice to have this as an xfs_buf_lru_add
helper.

> + /* remove from LRU */
> + spin_lock(&btp->bt_lru_lock);
> + list_del_init(&bp->b_lru);
> + btp->bt_lru_nr--;
> + spin_unlock(&btp->bt_lru_lock);

And this ad xfs_buf_lru_del.