Re: [PATCH 08/18] xfs: rename xfs_buf_get_nodaddr to be more appropriate

Alex Elder
2010-09-14T22:15:20Z

On Tue, 2010-09-14 at 20:56 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> xfs_buf_get_nodaddr() is really used to allocate a buffer that is
> uncached. While it is not directly assigned a disk address, the fact
> that they are not cached is a more important distinction. With the
> upcoming uncached buffer read primitive, we should be consistent
> with this disctinction.
>
> While there, make page allocation in xfs_buf_get_nodaddr() safe
> against memory reclaim re-entrancy into the filesystem by changing
> the allocation to GFP_NOFS.

This could be spun into its own patch (#19 or more). But
I don't think it's that important.

>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/linux-2.6/xfs_buf.c | 6 +++---
> fs/xfs/linux-2.6/xfs_buf.h | 2 +-

Looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>