Re: [PATCH 11/18] xfs: kill XBF_FS_MANAGED buffers

Alex Elder
2010-09-14T22:26:46Z

On Tue, 2010-09-14 at 20:56 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Filesystem level managed buffers are buffers that have their
> lifecycle controlled by the filesystem layer, not the buffer cache.
> We currently cache these buffers, which makes cleanup and cache
> walking somewhat troublesome. Convert the fs managed buffers to
> uncached buffers obtained by via xfs_buf_get_uncached(), and remove
> the XBF_FS_MANAGED special cases from the buffer cache.

Looks good. Nicer with the xfs_buf_read_uncached() helper.

Reviewed-by: Alex Elder <aelder@sgi.com>

> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/linux-2.6/xfs_buf.c | 20 +++------------
> fs/xfs/linux-2.6/xfs_buf.h | 4 ---
> fs/xfs/xfs_mount.c | 56 ++++++++++++-------------------------------
> 3 files changed, 20 insertions(+), 60 deletions(-)