From: Alex Elder <aelder@sgi.com>
To: Poyo VL <poyo_vl@yahoo.com>
Cc: xfs@oss.sgi.com
Subject: Re: Patch fs/xfs/xfs_alloc.c
Date: Thu, 16 Sep 2010 10:38:38 -0500 [thread overview]
Message-ID: <1284651518.2153.11.camel@doink> (raw)
In-Reply-To: <739371.35999.qm@web45805.mail.sp1.yahoo.com>
On Thu, 2010-09-02 at 00:41 -0700, Poyo VL wrote:
> Im using "gcc version 4.5.0 20100604 [gcc-4_5-branch revision 160292] (SUSE
> Linux)"
>
> Before compiling kernel (2.6.35.4) I selected from menuconfig all XFS "options":
> Quota supprt, POSIX ACL support, Realtime subvolume support and Debugging
> support. I saved the .config and I typed "make".
>
>
> I got the following warnings:
>
> fs/xfs/xfs_alloc.c: In function ‘xfs_alloc_ag_vextent_near’:
> fs/xfs/xfs_alloc.c:694:15: warning: ‘ltlena’ may be used uninitialized in this
> function
> fs/xfs/xfs_alloc.c:683:15: warning: ‘gtlena’ may be used uninitialized in this
> function
>
> So I tried to initialize those variables (structures) with 0.
>
> Sorry, I am not neither a C, nor a kernel expert.
I'm going to take this in (to top-of-tree), but
I'll be modifying it slightly (xfs_extlen_t is
not a struct, so I'll initialize with a simple 0).
It may well be that these variables never get used
without being set, but it's not at all clear from
a quick look so this is a simple fix.
Thanks for reporting the warning.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-09-16 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 19:27 Patch fs/xfs/xfs_alloc.c Poyo VL
2010-09-02 5:21 ` Dave Chinner
2010-09-02 7:41 ` Poyo VL
2010-09-16 15:38 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284651518.2153.11.camel@doink \
--to=aelder@sgi.com \
--cc=poyo_vl@yahoo.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox