From: Alex Elder <aelder@sgi.com>
To: "Arkadiusz Miśkiewicz" <arekm@maven.pl>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH VER 4] xfsprogs: projid32bit handling
Date: Thu, 23 Sep 2010 17:57:44 -0500 [thread overview]
Message-ID: <1285282664.1973.180.camel@doink> (raw)
In-Reply-To: <1285177520-11513-1-git-send-email-arekm@maven.pl>
On Wed, 2010-09-22 at 19:45 +0200, Arkadiusz Miśkiewicz wrote:
> Add projid32bit handling to userspace. mkfs is able to enable this
> feature for new filesystems. xfs_db knows what projid_lo/hi are.
I forgot to mention this before. Now that I see man
pages I think I should do so. You should use the term
"identifiers" rather than the (non-word) "identificators"
throughout.
A number of the comments I had on the kernel XFS code
apply to the user-space counterpart code here, so I
won't offer those comments here. I will just ask that
you make the two be consistent with each other where there
is matching code.
I haven't given this code a very thorough review, just
a scan for the most part. I'd like to hear your thoughts
on my suggestions from your XFS patch.
-Alex
> Signed-off-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
> ---
>
> What has changed?
> - sb_bad_features2 is also updated
> - bstat_get_projid helper added
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-09-23 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 17:42 [PATCH VER 4] Extend project quotas to support 32bit project identificators Arkadiusz Miśkiewicz
2010-09-22 17:45 ` [PATCH VER 4] xfsprogs: projid32bit handling Arkadiusz Miśkiewicz
2010-09-22 17:45 ` [PATCH VER 4] xfstests: Quota project id setting overflow Arkadiusz Miśkiewicz
2010-09-22 18:44 ` [PATCH VER 4] xfsprogs: projid32bit handling Christoph Hellwig
2010-09-23 22:57 ` Alex Elder [this message]
2010-09-22 18:42 ` [PATCH VER 4] Extend project quotas to support 32bit project identificators Christoph Hellwig
2010-09-22 19:01 ` Arkadiusz Miskiewicz
2010-09-24 0:37 ` Dave Chinner
2010-09-23 22:51 ` Alex Elder
2010-09-24 0:55 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285282664.1973.180.camel@doink \
--to=aelder@sgi.com \
--cc=arekm@maven.pl \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox