From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o8RFxcMS193925 for ; Mon, 27 Sep 2010 10:59:39 -0500 Subject: Re: [PATCH 13/18] xfs: split out inode walk inode grabbing From: Alex Elder In-Reply-To: <1285552073-14663-14-git-send-email-david@fromorbit.com> References: <1285552073-14663-1-git-send-email-david@fromorbit.com> <1285552073-14663-14-git-send-email-david@fromorbit.com> Date: Mon, 27 Sep 2010 10:58:56 -0500 Message-ID: <1285603136.2380.12.camel@doink> Mime-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, 2010-09-27 at 11:47 +1000, Dave Chinner wrote: > From: Dave Chinner > > When doing read side inode cache walks, the code to validate and > grab an inode is common to all callers. Split it out of the execute > callbacks in preparation for batching lookups. Similarly, split out > the inode reference dropping from the execute callbacks into the > main lookup look to be symmetric with the grab. > > Signed-off-by: Dave Chinner > Reviewed-by: Christoph Hellwig Looks good. Reviewed-by: Alex Elder _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs