From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alain Renaud <arenaud@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: Fix some file permission.
Date: Tue, 12 Oct 2010 15:13:51 -0500 [thread overview]
Message-ID: <1286914431.3750.3.camel@doink> (raw)
In-Reply-To: <20101010080502.GA6674@infradead.org>
On Sun, 2010-10-10 at 04:05 -0400, Christoph Hellwig wrote:
> On Sun, Oct 10, 2010 at 12:57:23PM +1100, Dave Chinner wrote:
> > > This looks good to me but I'd like a second opinion,
> > > to make sure there's no reason any of these should
> > > be non-executable.
> >
> > I don't think it matters. Consistency is good, though, and we've
> > taken patches like this in the past.
>
> Yeah. Btw, I'm not sure git-am can apply the mode changes from a patch,
> in the worst case you might have to do the chmod calls manually.
>
Just a follow-up... "git am" *does* do the right thing with
a git-generated patch that describes changes to modes only.
(But "patch" and "quilt" of course just think it's garbage.)
I've committed this change to the xfstests-dev tree on kernel.org
and will push it out to oss next time I update that tree (most
likely later this week).
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-10-12 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 22:22 [PATCH] xfstests: Fix some file permission Alain Renaud
2010-10-09 21:35 ` Alex Elder
2010-10-10 1:57 ` Dave Chinner
2010-10-10 8:05 ` Christoph Hellwig
2010-10-10 15:12 ` Alex Elder
2010-10-12 20:13 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286914431.3750.3.camel@doink \
--to=aelder@sgi.com \
--cc=arenaud@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox