From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups
Date: Mon, 29 Nov 2010 14:42:10 -0600 [thread overview]
Message-ID: <1291063330.2425.12.camel@doink> (raw)
In-Reply-To: <20101129145627.GB22839@infradead.org>
On Mon, 2010-11-29 at 09:56 -0500, Christoph Hellwig wrote:
> On Mon, Nov 29, 2010 at 08:28:05AM -0600, Bill Kendall wrote:
> > There are several modules in xfsrestore which map files. None of them
> > currently contain a destructor/cleanup function for unmapping the files.
> > It would be a good change to make though.
>
> If keeping it mapped later it's fine with me. So ACK from me for the
> whole series.
>
> Alex, maybe it's time to push out another xfsdump release after this?
> There's quite a few changes that have accumulated.
Yes, I had planned to do that once we got Bill's series
committed. I am doing a final test of it today before
pushing it to the -dev tree, for starters.
I also wanted to update my metadump series and, after
getting that committed, mark a new release for xfsprogs
as well. I thought I'd do these releases at the same
time but I guess they don't have to be.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-11-29 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 18:38 [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups Bill Kendall
2010-11-23 13:48 ` Christoph Hellwig
2010-11-29 14:28 ` Bill Kendall
2010-11-29 14:56 ` Christoph Hellwig
2010-11-29 20:42 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291063330.2425.12.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox