From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oB9LHstr082640 for ; Thu, 9 Dec 2010 15:17:54 -0600 Subject: Re: [PATCH] xfstests: fix 108 golden output From: Alex Elder In-Reply-To: <20101110125855.GA18357@infradead.org> References: <20101110125855.GA18357@infradead.org> Date: Thu, 09 Dec 2010 15:19:39 -0600 Message-ID: <1291929579.13355.30.camel@doink> Mime-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: branto@redhat.com, xfs@oss.sgi.com On Wed, 2010-11-10 at 07:58 -0500, Christoph Hellwig wrote: > The new common scratch mount filter produces slightly different > whitespaces than the old home grown filter, so adjust the golden > output. > > Signed-off-by: Christoph Hellwig I found out why this is happening. I get no such error, and Dave Chinner said he wasn't seeing it either. xfs_quota is formatting its output such that the second and later columns always align at a certain offset from the beginning of the line. As a result, path names assigned as SCRATCH_DEV of different lengths will produce different (filtered) output, with more or fewer blanks between SCRATCH_DEV and the usage number. Boris Ranto has proposed a change that would add the "-b" flag to diff when checking output against golden output. That should fix it, but it's possible we *want* differences in white space to matter in some cases. Have to look into this. -Alex _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs