From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfs: refactor xlog_recover_commit_trans
Date: Thu, 16 Dec 2010 15:18:15 -0600 [thread overview]
Message-ID: <1292534295.2457.58.camel@doink> (raw)
In-Reply-To: <20101201220710.454838485@bombadil.infradead.org>
On Wed, 2010-12-01 at 17:06 -0500, Christoph Hellwig wrote:
>
> Merge the call to xlog_recover_reorder_trans and the loop over the
> recovery items from xlog_recover_do_trans into xlog_recover_commit_trans,
> and keep the switch statement over the log item types as a separate helper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
I'm making a small change to this one patch though...
. . .
> @@ -2757,17 +2699,65 @@ xlog_recover_free_trans(
> }
>
> STATIC int
> +xlog_recover_commit_item(
> + struct log *log,
> + struct xlog_recover *trans,
> + xlog_recover_item_t *item,
> + int pass)
> +{
> + trace_xfs_log_recover_item_recover(log, trans, item, pass);
> +
> + switch (ITEM_TYPE(item)) {
> + case XFS_LI_BUF:
> + return xlog_recover_do_buffer_trans(log, item, pass);
> + break;
I have deleted this "break" statement.
> + case XFS_LI_INODE:
> + return xlog_recover_do_inode_trans(log, item, pass);
> + case XFS_LI_EFI:
> + return xlog_recover_do_efi_trans(log, item, trans->r_lsn, pass);
> + case XFS_LI_EFD:
> + xlog_recover_do_efd_trans(log, item, pass);
> + return 0;
. . .
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-12-16 21:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 22:06 [PATCH 0/4] log recovery cleanups Christoph Hellwig
2010-12-01 22:06 ` [PATCH 1/4] xfs: remove leftovers of old buffer log items in recovery code Christoph Hellwig
2010-12-23 1:50 ` Dave Chinner
2010-12-01 22:06 ` [PATCH 2/4] xfs: use struct list_head for the buf cancel table Christoph Hellwig
2010-12-23 1:54 ` Dave Chinner
2010-12-01 22:06 ` [PATCH 3/4] xfs: refactor xlog_recover_commit_trans Christoph Hellwig
2010-12-16 21:18 ` Alex Elder [this message]
2010-12-20 11:28 ` Christoph Hellwig
2010-12-23 1:56 ` Dave Chinner
2010-12-01 22:06 ` [PATCH 4/4] xfs: untangle phase1 vs phase2 recovery helpers Christoph Hellwig
2010-12-23 2:06 ` Dave Chinner
2010-12-16 21:14 ` [PATCH 0/4] log recovery cleanups Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292534295.2457.58.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox