From: Alex Elder <aelder@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/5] percpu_counter: fix test in __percpu_counter_add_unless_lt()
Date: Wed, 29 Dec 2010 15:49:20 -0600 [thread overview]
Message-ID: <1293659360.1961.474.camel@doink> (raw)
In-Reply-To: <1293656188.1961.470.camel@doink>
On Wed, 2010-12-29 at 14:56 -0600, Alex Elder wrote:
> if (new_count >= threshold) {
> ret = new_count > threshold;
> fbc->count = fbc_count + amount;
> }
> spin_unlock(&fbc->lock);
>
> return ret;
> }
I obviously didn't test the code I sent, but
you get what I mean... Here is the way one of
the lines above should look:
fbc->count = fbc->count + amount;
Or even better:
fbc->count += amount;
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-12-29 21:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 3:56 [PATCH 1/5] percpu_counter: fix test in __percpu_counter_add_unless_lt() Alex Elder
2010-12-23 6:06 ` Dave Chinner
2010-12-29 20:56 ` Alex Elder
2010-12-29 21:49 ` Alex Elder [this message]
2010-12-30 22:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293659360.1961.474.camel@doink \
--to=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox