From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p051xftt075310 for ; Tue, 4 Jan 2011 19:59:41 -0600 Subject: Re: [PATCH] xfs: ensure log covering transactions are synchronous From: Alex Elder In-Reply-To: <1294116569-15052-1-git-send-email-david@fromorbit.com> References: <1294116569-15052-1-git-send-email-david@fromorbit.com> Date: Tue, 04 Jan 2011 20:01:46 -0600 Message-ID: <1294192906.2485.730.camel@doink> Mime-Version: 1.0 Reply-To: aelder@sgi.com List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, 2011-01-04 at 15:49 +1100, Dave Chinner wrote: > From: Dave Chinner > > To ensure the log is covered and the filesystem idles correctly, we > need to ensure that dummy transactions hit the disk and do not stay > pinned in memory. If the superblock is pinned in memory, it can't > be flushed so the log covering cannot make progress. The result is > dependent on timing - more oftent han not we continue to issues a > log covering transaction every 36s rather than idling after ~90s. > > Fix this by making the log covering transaction synchronous. To > avoid additional log force from xfssyncd, make the log covering > transaction take the place of the existing log force in the xfssyncd > background sync process. > Looks good. Reviewed-by: Alex Elder > Signed-off-by: Dave Chinner > --- _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs