From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 02/12] xfsprogs: simplify leading '/' handling in generate_obfuscated_name()
Date: Mon, 10 Jan 2011 14:23:57 -0600 [thread overview]
Message-ID: <1294691037.5374.49.camel@doink> (raw)
In-Reply-To: <20110110201335.GB27277@infradead.org>
On Mon, 2011-01-10 at 15:13 -0500, Christoph Hellwig wrote:
> On Thu, Dec 30, 2010 at 02:40:12PM -0600, Alex Elder wrote:
> > In generate_obfuscated_name(), the incoming file name is allowed to
> > start with a '/' character, in which case it is copied over to the
> > new file name and ignored for the remainder of the hash calculation.
> > Simplify the affected code by processing the '/' right away, and
> > using a pointer thereafter for the start of the new file name.
>
> The actual change looks good to me, but why would we ever have a /
> in the filename, and if we do why would we treat it special?
>
This change was preserving the behavior that was there before.
I didn't ask that question... It may well be that there's no
need to even handle a filename starting with '/', but I didn't
follow it back to see.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-01-10 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 20:40 [PATCH 02/12] xfsprogs: simplify leading '/' handling in generate_obfuscated_name() Alex Elder
2011-01-10 20:13 ` Christoph Hellwig
2011-01-10 20:23 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294691037.5374.49.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox